Repository navigation
chore: rebase the custom-scheme code cache patch onto upstream's checks - #53746
Merged
Conversation
feat_allow_code_cache_in_custom_schemes.patch rewrote CheckSecurityForAccessingCodeCacheData and the two DCHECK helpers in generated_code_cache.cc wholesale, and in doing so dropped the CommonSchemeRegistry::IsExtensionScheme branches Chromium added later and refused http(s) script caching for any process not locked to http(s) or an embedder scheme (file:// pages, standard custom schemes without codeCache). Keep upstream's logic verbatim and only add the embedder-scheme cases via a new url::IsCodeCacheScheme() helper. Co-authored-by: Shelley Vohr <[email protected]>
3 tasks done
trop
Bot
added
45-x-y
backport
ckerr
approved these changes
Sep 8, 2026
jkleinsc
approved these changes
Sep 8, 2026
|
Release Notes Persisted
|
codebytere
deleted the
trop/45-x-y-bp-chore-rebase-the-custom-scheme-code-cache-patch-onto-upstream-s-checks-1788891078025
branch
September 8, 2026 20:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #53676
See that PR for details.
Notes: Fixed V8 code caching for https scripts loaded by
file://and custom-scheme pages.