Repository navigation
fix: require a registered source id for webContents capture via getUserMedia - #53687
Merged
Merged
Conversation
…erMedia * the legacy `chromeMediaSource: 'desktop'` getUserMedia path only accepts screen and window ids; a `web-contents-media-stream://` id there is rejected with "Invalid state" instead of starting a capture of that WebContents * WebContents capture keeps working through `chromeMediaSource: 'tab'` with an id from webContents.getMediaSourceId() (bound to the requesting contents) and through setDisplayMediaRequestHandler * spec + getMediaSourceId doc note
MarshallOfSound
added
semver/patch
VerteDinde
approved these changes
Sep 7, 2026
codebytere
approved these changes
Sep 7, 2026
|
Release Notes Persisted
|
This was referenced Sep 7, 2026
Contributor
|
I have automatically backported this PR to "43-x-y", please check out #53707 |
Contributor
|
I have automatically backported this PR to "45-x-y", please check out #53708 |
trop
Bot
added
in-flight/45-x-y
and removed
target/43-x-y
Contributor
|
I have automatically backported this PR to "44-x-y", please check out #53709 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #53710 |
trop
Bot
added
in-flight/44-x-y
in-flight/42-x-y
merged/45-x-y
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chromeMediaSource: 'desktop'getUserMediaconstraint accepts screen and window source ids only; aweb-contents-media-stream://id there is rejected with "Invalid state".chromeMediaSource: 'tab'with an id fromwebContents.getMediaSourceId()(bound to the requesting contents) and throughsetDisplayMediaRequestHandler.getMediaSourceIddoc note.Notes:
getUserMediawithchromeMediaSource: 'desktop'no longer accepts WebContents source ids; usechromeMediaSource: 'tab'withwebContents.getMediaSourceId()orsetDisplayMediaRequestHandlerto capture a WebContents.