Repository navigation
test: deflake test-worker-stack-overflow-stack-size in the Node.js suite - #53062
Merged
Merged
Conversation
Backports nodejs/node#64271. The test compares the recursion depth two Workers reach before overflowing, but depth also depends on frame size, which changes when the recursive function tiers up mid-recursion. On a busy CI runner that lands non-deterministically and the depths end up >10% apart. Pin the function to the interpreter so the depth is stable. The fix is only in Node 26.6.0+, so it is carried as a patch until the Node roll picks it up.
MarshallOfSound
added
semver/none
target/41-x-y
MarshallOfSound
enabled auto-merge (squash)
August 21, 2026 06:44
deepak1556
approved these changes
Aug 21, 2026
dsanders11
approved these changes
Aug 21, 2026
MarshallOfSound
disabled auto-merge
August 21, 2026 09:56
|
No Release Notes |
This was referenced Aug 21, 2026
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #53075 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #53076 |
Contributor
|
I have automatically backported this PR to "44-x-y", please check out #53077 |
trop
Bot
added
in-flight/42-x-y
and removed
target/41-x-y
Contributor
|
I have automatically backported this PR to "43-x-y", please check out #53078 |
trop
Bot
added
in-flight/44-x-y
in-flight/43-x-y
and removed
target/42-x-y
trop
Bot
added
merged/41-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
patches/nodepatch.parallel/test-worker-stack-overflow-stack-sizecompares the recursion depth two Workers reach before overflowing; depth also depends on frame size, which changes if the recursive function tiers up mid-recursion, so on a loaded runner the two depths land >10% apart (e.g.w1stack = 62263, w2stack = 82360 are too far apartin this nn-test run). The upstream fix pins the function to the interpreter with%NeverOptimizeFunction.Checklist
Release Notes
Notes: none