fix: only set Node's WASM streaming callback when fetch is enabled (#…#52240
Merged
Conversation
trop
Bot
added
41-x-y
backport
3 tasks
electron-cation
Bot
added
new-pr 🌱
nmggithub
approved these changes
Jul 2, 2026
3 tasks
jkleinsc
requested changes
Jul 2, 2026
jkleinsc
left a comment
jkleinsc
left a comment
Member
There was a problem hiding this comment.
Can you rebase and update the patch(es)?
…51953) * fix: only set Node's WASM streaming callback when fetch is enabled Node.js v24.16.0 removed the experimental_fetch gate around isolate->SetWasmStreamingCallback() (nodejs/node#62759). When fix_allow_disabling_fetch_in_renderer_and_worker_processes.patch was rebased for the version bump, the flag was restored but the gate was not. As a result, Node.js unconditionally overrode Blink's WebAssembly streaming callback in renderer and worker processes, where Electron passes --no-experimental-fetch and skips the bootstrap file that registers Node's JS-side streaming implementation. Any call to WebAssembly.compileStreaming() or instantiateStreaming() in a renderer with nodeIntegration then failed the CHECK(\!impl.IsEmpty()) assertion in node_wasm_web_api.cc and crashed the renderer. Restore the gate so Blink's streaming callback stays in place in processes where Node's fetch is disabled. Fixes #51950 * test: cover WebAssembly streaming compilation in renderers with nodeIntegration
mlaurencin
force-pushed
the
bp-fix-only-set-node-s-wasm-backport-41xy
branch
from
July 2, 2026 20:33
6e93c0e to
ef74fd5
Compare
dsanders11
approved these changes
Jul 2, 2026
jkleinsc
approved these changes
Jul 13, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51953
See that PR for details.
Notes: Fixed a renderer crash when calling
WebAssembly.compileStreaming()orWebAssembly.instantiateStreaming()withnodeIntegrationenabled.