Skip to content

build: track PDL files as inputs in inspector GN build#51239

Merged
codebytere merged 2 commits into
mainfrom
robo/fix_inspector_source_gn
Apr 22, 2026
Merged

build: track PDL files as inputs in inspector GN build#51239
codebytere merged 2 commits into
mainfrom
robo/fix_inspector_source_gn

Conversation

@deepak1556

@deepak1556 deepak1556 commented Apr 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description of Change

Fixes the following build error due to stale headers, followup to #51091

In file included from ../../third_party/electron_node/src/inspector/target_agent.cc:1:
../../third_party/electron_node/src/inspector/target_agent.h:28:7: error: only virtual member functions can be marked 'override'
   28 |       override;
      |       ^~~~~~~~
1 error generated.

build failed

Release Notes

Notes: none

@deepak1556
deepak1556 requested a review from a team as a code owner April 22, 2026 06:08
@deepak1556
deepak1556 requested a review from codebytere April 22, 2026 06:08
codebytere
codebytere previously approved these changes Apr 22, 2026
View reviewed changes
@codebytere
codebytere dismissed their stale review April 22, 2026 07:17

@deepak1556 can you put this in the existing build.gn patch?

@deepak1556
deepak1556 requested a review from codebytere April 22, 2026 10:27
@deepak1556 deepak1556 mentioned this pull request Apr 22, 2026
Merged
@codebytere
codebytere enabled auto-merge (squash) April 22, 2026 13:32
@codebytere
codebytere merged commit 111b627 into main Apr 22, 2026
121 of 123 checks passed
@codebytere
codebytere deleted the robo/fix_inspector_source_gn branch April 22, 2026 13:48
@release-clerk

release-clerk Bot commented Apr 22, 2026

Copy link
Copy Markdown

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

no-backport semver/none

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deepak1556 @codebytere