chore: bump node to v24.15.0 (main)#51091
Merged
Merged
Conversation
electron-roller
Bot
added
semver/patch
Upstream replaced the hardcoded buffer length limit with a runtime kMaxLength variable, making the patch's regex workaround for sandbox vs non-sandbox limits unnecessary. Dropped the test-buffer-concat.js hunk. Ref: nodejs/node#61721 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Upstream removed Uint32ToName from node_contextify.cc and node_webstorage.cc, and renamed LookupAndCompile to LookupAndCompileFunction in node_builtins.cc. Updated the GetIsolate deprecation patch to match. Ref: nodejs/node#60846 Ref: nodejs/node#60518 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
The fix_generate_config_gypi_needs_to_generate_valid_json patch applied with "No changes -- Patch already applied", confirming the fix has been incorporated upstream. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Upstream restructured BuiltinLoader to auto-detect parameters by source type, removing the custom parameters overload. Added a new LookupAndCompileFunction overload for embedder scripts and updated node_util.cc to use it. Also suppressed exit-time-destructors warning from builtin_info.h in node_includes.h. Ref: nodejs/node#60518 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Ref: nodejs/node#60518 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Ref: nodejs/node#60616 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
codebytere
force-pushed
the
roller/node/main
branch
from
April 16, 2026 19:59
11252c2 to
2d8693e
Compare
codebytere
force-pushed
the
roller/node/main
branch
from
April 17, 2026 08:54
2d8693e to
144c4f1
Compare
Guard aes-128-ccm test in test-crypto-authenticated.js behind cipher availability check. Skip Ed448/X448/DSA tests in test-crypto-key-objects-raw.js. Skip AES-KW tests in test-webcrypto-promise-prototype-pollution.mjs. Ref: nodejs/node#62240 Ref: nodejs/node#62455 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
BoringSSL does not support loading DH private keys from PEM, causing createPrivateKey to throw UNSUPPORTED_ALGORITHM. Ref: nodejs/node#62240 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
The snapshot used `*` wildcards which don't match the actual output. Regenerated with NODE_REGENERATE_SNAPSHOTS=1 to capture the correct concrete frame + <node-internal-frames> output. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/6826001 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
deepak1556
reviewed
Apr 20, 2026
| v8::Local<v8::Context> context, const char* id, Realm* optional_realm); | ||
|
|
||
| + // Overload that accepts custom parameters for embedder scripts. | ||
| + v8::MaybeLocal<v8::Function> LookupAndCompileFunction( |
Member
There was a problem hiding this comment.
Curious, could we adjust our builtins to match one of the established parameter types https://github.com/nodejs/node/blob/14e16db1bf41737eaf45382585dfa89da23f6fca/src/builtin_info.h#L27-L48 so we can drop the overload ?
Member
There was a problem hiding this comment.
probably - i can look into it in a follow up!
deepak1556
approved these changes
Apr 20, 2026
|
Release Notes Persisted
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Node.js to v24.15.0.
See all changes in v24.14.1..v24.15.0
Notes: Updated Node.js to v24.15.0.