Repository navigation
Conversation
Contributor
|
For more information on signing commits, see GitHub's documentation on Telling Git about your signing key. |
github-actions
Bot
added
the
needs-signed-commits
Member
|
Heads up: Windows CI builds moved to new runners on Monday and the old ones have now been removed. This branch predates that, so its Windows build jobs still point at the old runners and will sit queued forever if CI runs again. Rebasing on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Handle top-level
Page.reloadcommands sent throughwebContents.debugger.sendCommand()with Electron'sWebContentsreload path instead of forwarding raw CDP to the target.Electron already special-cases
Page.reloadfrom the DevTools frontend inInspectableWebContents::DispatchProtocolMessageFromDevToolsFrontend. The debugger API path bypassed that special-case and sent the raw protocol message directly throughDevToolsAgentHost::DispatchProtocolMessage.This matters for guest
<webview>contents: raw CDPPage.reloadcan reload the embedder window instead of only the guest. The new handling preservesignoreCacheand leaves session-targeted commands unchanged.Checklist
Page.reloadagainst a<webview>guestNotes
I have not run the Electron test suite locally from this sparse checkout. This patch is based on a downstream repro where
webContents.debugger.sendCommand('Page.reload')against a<webview>guest caused the embedder BrowserWindow renderer to reload, whileguestWebContents.reload()reloaded only the guest.