Skip to content

feat: respect linux wco button order - #50978

Closed
tarik02 wants to merge 1 commit into
electron:mainfrom
tarik02:linux-wco-button-order
Closed

tarik02 wants to merge 1 commit into
electron:mainfrom
tarik02:linux-wco-button-order

Conversation

@tarik02

@tarik02 tarik02 commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Description of Change

Change was assisted by OpenAI codex. I understand what this change brings:

  • instead of having one view container for window buttons, we have up to two (one on left and one on right, depending on buttons layout)
  • we already have a way to know correct order - just don't use it

Before this change:
image

After this change:
image

Checklist

Release Notes

Notes:
WCO respected the title bar order defined in system settings.

Assisted-By: OpenAI Codex
@welcome

welcome Bot commented Apr 12, 2026

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codebytere

Copy link
Copy Markdown
Member

Sorry but this code is equally incorrect and full of errors as the original one i closed - we can't accept this per our AI policy. You're welcome to file an issue and a maintainer can take a look at fixing it properly.

@codebytere codebytere closed this Apr 13, 2026
@tarik02 tarik02 mentioned this pull request Apr 13, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pr 🌱 PR opened recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants