Skip to content

refactor: remove dead named-window lookup from guest-window-manager#50496

Merged
jkleinsc merged 1 commit into
42-x-yfrom
trop/42-x-y-bp-refactor-remove-dead-named-window-lookup-from-guest-window-manager-1774460935395
Mar 26, 2026
Merged

refactor: remove dead named-window lookup from guest-window-manager#50496
jkleinsc merged 1 commit into
42-x-yfrom
trop/42-x-y-bp-refactor-remove-dead-named-window-lookup-from-guest-window-manager-1774460935395

Conversation

@trop

@trop trop Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Backport of #50474

See that PR for details.

Notes: none

The frameNamesToWindow map was a holdover from the BrowserWindowProxy
IPC shim. Since nativeWindowOpen became the only code path, Blink's
FrameTree::FindOrCreateFrameForNavigation resolves named window targets
directly in the renderer, scoped to the opener's browsing context
group. When a matching named window exists, Blink navigates it without
ever sending a CreateNewWindow IPC to the browser, so this map was
never consulted in the legitimate same-opener case.

The only time the map found a match was when two unrelated renderers
happened to use the same target name, in which case openGuestWindow
would short-circuit before consuming the guest WebContents that
Chromium had already created for the new window, leaking it.

Adds a test verifying Blink handles same-opener named-target reuse
end-to-end without any browser-side tracking.

Co-authored-by: Sam Attard <[email protected]>
@trop trop Bot requested review from a team and MarshallOfSound March 25, 2026 17:49
@trop trop Bot added 42-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 25, 2026
@jkleinsc jkleinsc merged commit 8f0f840 into 42-x-y Mar 26, 2026
167 of 172 checks passed
@jkleinsc jkleinsc deleted the trop/42-x-y-bp-refactor-remove-dead-named-window-lookup-from-guest-window-manager-1774460935395 branch March 26, 2026 15:46
@release-clerk

release-clerk Bot commented Mar 26, 2026

Copy link
Copy Markdown

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

42-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants