fix: correct utility process exit code on Windows#50386
Merged
dsanders11 merged 2 commits intoMar 20, 2026
Merged
Conversation
On Windows, process exit codes are 32-bit unsigned integers (DWORD). When passed from Chromium to Electron as a signed int and then implicitly converted to uint64_t, values with the high bit set (e.g., NTSTATUS codes) undergo sign extension, producing incorrect values. Cast the exit code to uint32_t before widening to uint64_t to prevent sign extension and preserve the original Windows exit code. Fixes #49455 Co-authored-by: João Silva <[email protected]>
Co-authored-by: João Silva <[email protected]>
3 tasks
trop
Bot
added
41-x-y
backport
dsanders11
approved these changes
Mar 20, 2026
dsanders11
deleted the
trop/41-x-y-bp-fix-correct-utility-process-exit-code-on-windows-1773953903839
branch
|
Release Notes Persisted
|
gregpriday
added a commit
to daintreehq/daintree
that referenced
this pull request
May 20, 2026
- workspace-host: add setImmediate(() => process.exit(1)) to both fatal handlers, matching pty-host symmetry. Electron 37+ no longer crashes utility processes on unhandledRejection; without explicit exit the parent's child-process-gone supervision path never fires. - PtyHostLifecycle and WorkspaceHostProcess: update stale comments to reference electron/electron#50386 (Windows exit-code mangling, fixed in 41.0.4) and #42283 (exit/child-process-gone ordering race). Defense-in-depth code preserved. - Add scripts/ci/check-crash-loop-constants.mjs to assert the three crash-loop constants stay equal across both host lifecycle files. Wired into npm run check. The constants remain duplicated by design. Closes #8698
gregpriday
added a commit
to daintreehq/daintree
that referenced
this pull request
May 20, 2026
- workspace-host: add setImmediate(() => process.exit(1)) to both fatal handlers, matching pty-host symmetry. Electron 37+ no longer crashes utility processes on unhandledRejection; without explicit exit the parent's child-process-gone supervision path never fires. - PtyHostLifecycle and WorkspaceHostProcess: update stale comments to reference electron/electron#50386 (Windows exit-code mangling, fixed in 41.0.4) and #42283 (exit/child-process-gone ordering race). Defense-in-depth code preserved. - Add scripts/ci/check-crash-loop-constants.mjs to assert the three crash-loop constants stay equal across both host lifecycle files. Wired into npm run check. The constants remain duplicated by design. Closes #8698
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50256
See that PR for details.
Notes: Fixed utilityProcess exit event reporting incorrect exit codes on Windows when the exit code has the high bit