Skip to content

fix: MAS rejection for private APIs#49391

Merged
codebytere merged 1 commit into
mainfrom
fix-mas-rejection
Jan 18, 2026
Merged

fix: MAS rejection for private APIs#49391
codebytere merged 1 commit into
mainfrom
fix-mas-rejection

Conversation

@codebytere

@codebytere codebytere commented Jan 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description of Change

Closes #49386

Preprocesses out unguarded private API usages on macOS:

  • _toolbarView ✅
  • _menuImpl
  • _removeFromGroups: ✅
  • _isConsideredOpenForPersistentState ✅
  • _boundsIfOpen ✅
  • _resizeDirectionForMouseLocation: ✅
  • NSAppendToKillRing ✅
  • kCFBundleNumericVersionKey ✅
  • __NSNewKillRingSequence ✅
  • _CGSSetWindowCaptureExcludeShape 🔴 Removed Upstream
  • _CGRegionCreateWithRect 🔴 Removed Upstream
  • _CTFontCopyVariationAxesInternal 🔴 Removed Upstream
  • __NSInitializeKillRing ✅
  • NSYankFromKillRing ✅
  • NSSetKillRingToYankedState ✅

Checklist

Release Notes

Notes: none

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Jan 14, 2026
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/38-x-y PR should also be added to the "38-x-y" branch. target/39-x-y PR should also be added to the "39-x-y" branch. target/40-x-y PR should also be added to the "40-x-y" branch. labels Jan 14, 2026
@codebytere codebytere force-pushed the fix-mas-rejection branch 2 times, most recently from ec4f1e5 to 49e5332 Compare January 15, 2026 09:10
@codebytere codebytere marked this pull request as ready for review January 15, 2026 11:25
@codebytere codebytere requested a review from a team as a code owner January 15, 2026 11:25
dsanders11
dsanders11 approved these changes Jan 16, 2026
View reviewed changes

@dsanders11 dsanders11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has a patch conflict due to the patch changes on main, but otherwise LGTM.

@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Jan 16, 2026
@codebytere codebytere merged commit faa21a7 into main Jan 18, 2026
104 of 105 checks passed
@codebytere codebytere deleted the fix-mas-rejection branch January 18, 2026 09:34
@release-clerk

release-clerk Bot commented Jan 18, 2026

Copy link
Copy Markdown

No Release Notes

@trop

trop Bot commented Jan 18, 2026

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "38-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot removed the target/38-x-y PR should also be added to the "38-x-y" branch. label Jan 18, 2026
@trop

trop Bot commented Jan 18, 2026

Copy link
Copy Markdown
Contributor

I was unable to backport this PR to "39-x-y" cleanly;
you will need to perform this backport manually.

@trop trop Bot added needs-manual-bp/38-x-y needs-manual-bp/39-x-y and removed target/39-x-y PR should also be added to the "39-x-y" branch. labels Jan 18, 2026
@trop trop Bot mentioned this pull request Jan 18, 2026
Merged
@trop

trop Bot commented Jan 18, 2026

Copy link
Copy Markdown
Contributor

I have automatically backported this PR to "40-x-y", please check out #49431

@trop trop Bot added in-flight/40-x-y merged/40-x-y PR was merged to the "40-x-y" branch. and removed target/40-x-y PR should also be added to the "40-x-y" branch. in-flight/40-x-y labels Jan 18, 2026
@michalzaq12

michalzaq12 commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@codebytere Did Electron use these methods? Will removing these private APIs have any consequences?

@DruidEdu

DruidEdu commented Jan 27, 2026

Copy link
Copy Markdown

@codebytere Hi, thanks for fixing this issue! Could you please let me know in which release this fix will be included, and approximately when that release will be published?

@samuelmaddock samuelmaddock mentioned this pull request Feb 19, 2026
Closed
3 tasks
@ckerr ckerr mentioned this pull request Mar 6, 2026
Merged
4 tasks
@dsanders11 dsanders11 mentioned this pull request May 5, 2026
Merged
@trop

trop Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

@dsanders11 has manually backported this PR to "39-x-y", please check out #51502

@trop trop Bot added in-flight/39-x-y merged/39-x-y PR was merged to the "39-x-y" branch. and removed needs-manual-bp/39-x-y in-flight/39-x-y labels May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes
@jkleinsc jkleinsc Awaiting requested review from jkleinsc
@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

No one assigned

Labels

merged/39-x-y PR was merged to the "39-x-y" branch. merged/40-x-y PR was merged to the "40-x-y" branch. needs-manual-bp/38-x-y semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MAS Rejection]:Private APIs in Electron Framework (NSAppendToKillRing, _toolbarView, etc.)

4 participants

@codebytere @michalzaq12 @DruidEdu @dsanders11