test: rerun failed tests individually #48205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
jkleinsc
force-pushed
the
rerun-failed-tests
branch
3 times, most recently
from
536b059 to
307b598
Compare
4 tasks
jkleinsc
force-pushed
the
rerun-failed-tests
branch
2 times, most recently
from
8d3d043 to
0ee88e2
Compare
jkleinsc
force-pushed
the
rerun-failed-tests
branch
from
29ed9ce to
a4e297f
Compare
jkleinsc
added
target/36-x-y
reitowo
reviewed
Sep 15, 2025
jkleinsc
force-pushed
the
rerun-failed-tests
branch
from
a4e297f to
799ca28
Compare
Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio.
No longer needed because of the addition of the screencapture-nag-remover script. This reverts commit f4a7e04.
jkleinsc
force-pushed
the
rerun-failed-tests
branch
from
799ca28 to
4ef17c2
Compare
reitowo
approved these changes
Sep 16, 2025
Member
|
I thought I could see this PR in action right in this CI, but find out it actually all passed at first time! XD |
Member
|
@electron/wg-infra could this get a review? #48291 is still causing a lot of CI failures |
VerteDinde
approved these changes
Sep 24, 2025
codebytere
approved these changes
Sep 24, 2025
Contributor
Contributor
Merged
5 tasks
jkleinsc
added a commit
that referenced
this pull request
Sep 26, 2025
test: rerun failed tests individually (#48205) * test: rerun failed tests individually * ci: use screencapture-nag-remover Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio. * Revert "chore: test with 1st quadrant of the window" No longer needed because of the addition of the screencapture-nag-remover script. This reverts commit f4a7e04. * test: fixup navigationHistory flake * rerun test up to 3 times
trop
bot
added
merged/39-x-y
Contributor
trop
bot
added
in-flight/36-x-y
merged/38-x-y
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
* test: rerun failed tests individually * ci: use screencapture-nag-remover Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio. * Revert "chore: test with 1st quadrant of the window" No longer needed because of the addition of the screencapture-nag-remover script. This reverts commit f4a7e04. * test: fixup navigationHistory flake * rerun test up to 3 times
trop
bot
added
merged/36-x-y
TheCommieAxolotl
pushed a commit
to TheCommieAxolotl/electron
that referenced
this pull request
Nov 2, 2025
* test: rerun failed tests individually * ci: use screencapture-nag-remover Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio. * Revert "chore: test with 1st quadrant of the window" No longer needed because of the addition of the screencapture-nag-remover script. This reverts commit f4a7e04. * test: fixup navigationHistory flake * rerun test up to 3 times
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
* test: rerun failed tests individually * ci: use screencapture-nag-remover Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio. * Revert "chore: test with 1st quadrant of the window" No longer needed because of the addition of the screencapture-nag-remover script. This reverts commit f4a7e04. * test: fixup navigationHistory flake * rerun test up to 3 times
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
* test: rerun failed tests individually * ci: use screencapture-nag-remover Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio. * Revert "chore: test with 1st quadrant of the window" No longer needed because of the addition of the screencapture-nag-remover script. This reverts commit f4a7e04. * test: fixup navigationHistory flake * rerun test up to 3 times
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
* test: rerun failed tests individually * ci: use screencapture-nag-remover Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio. * Revert "chore: test with 1st quadrant of the window" No longer needed because of the addition of the screencapture-nag-remover script. This reverts commit f4a7e04. * test: fixup navigationHistory flake * rerun test up to 3 times
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR was inspired by a conversation with @reitowo. It adds logic to rerun failed tests individually. This should help avoid having to do full reruns of test suites when flakes happen.
Additionally, this PR fixes a CI issue where a macOS system dialog was appearing with the following text which broke/interfered with some of our tests:
Checklist
npm testpassesRelease Notes
Notes: none