Skip to content

Conversation

@tmm1
Copy link
Contributor

@tmm1 tmm1 commented Apr 20, 2025

backport of #46690

@tmm1 tmm1 requested a review from a team as a code owner April 20, 2025 02:51
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 20, 2025
@trop trop bot requested a review from a team April 20, 2025 02:51
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 20, 2025
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't raise backport PRs until the original is approved.

As an aside IMO it is unlikely that we accept a 2000 line patch to node in v34 specifically, our rule is that it should be consistent which means that v35 and v36 should receive it too. And the sheer size of this patch is IMO too much to accept

@tmm1 tmm1 closed this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants