Skip to content

Comments

feat: redesign preload APIs#45329

Merged
samuelmaddock merged 8 commits into35-x-yfrom
trop/35-x-y-bp-feat-redesign-preload-apis-1737684757487
Jan 31, 2025
Merged

feat: redesign preload APIs#45329
samuelmaddock merged 8 commits into35-x-yfrom
trop/35-x-y-bp-feat-redesign-preload-apis-1737684757487

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Jan 24, 2025

Backport of #45230

See that PR for details.

Notes:

  • Redesigned preload script APIs by introducing registerPreloadScript, unregisterPreloadScript, getPreloadScripts on Session.
  • Deprecated getPreloads and setPreloads on Session.

trop bot and others added 8 commits January 24, 2025 02:12
Co-authored-by: Samuel Maddock <[email protected]>
Co-authored-by: Samuel Maddock <[email protected]>
Co-authored-by: Samuel Maddock <[email protected]>
Co-authored-by: Samuel Maddock <[email protected]>
Co-authored-by: Samuel Maddock <[email protected]>
@trop trop bot requested review from a team as code owners January 24, 2025 02:13
@trop trop bot requested a review from samuelmaddock January 24, 2025 02:13
@trop trop bot mentioned this pull request Jan 24, 2025
5 tasks
@trop trop bot added 35-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Jan 24, 2025
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases on Jan 30 2025

@samuelmaddock samuelmaddock merged commit 9d696ce into 35-x-y Jan 31, 2025
61 of 62 checks passed
@samuelmaddock samuelmaddock deleted the trop/35-x-y-bp-feat-redesign-preload-apis-1737684757487 branch January 31, 2025 14:46
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2025

Release Notes Persisted

  • Redesigned preload script APIs by introducing registerPreloadScript, unregisterPreloadScript, getPreloadScripts on Session.
  • Deprecated getPreloads and setPreloads on Session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

35-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants