Conversation
samuelmaddock
added
semver/minor
23 tasks
jkleinsc
approved these changes
Jan 23, 2025
Member
jkleinsc
left a comment
jkleinsc
left a comment
There was a problem hiding this comment.
Code LGTM - thanks for adding tests!
samuelmaddock
force-pushed
the
feat/service-worker-main
branch
from
8ad7b07 to
96dedfd
Compare
electron-cation
bot
added
api-review/approved ✅
and removed
new-pr 🌱
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "35-x-y" cleanly; |
trop
bot
added
needs-manual-bp/35-x-y
and removed
target/35-x-y
5 tasks
Contributor
|
@samuelmaddock has manually backported this PR to "35-x-y", please check out #45341 |
trop
bot
added
in-flight/35-x-y
merged/35-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Split from #44411
Implements part of RFC #8
Tracks lifetime of
content::ServiceWorkerVersion. This class lives as long as a service worker registration is live. A new instance is required for each new 'version' of a service worker script installed.Only
scopeandversionIdare currently exposed. This isn't too useful until IPC support is added in a follow up PR.Checklist
npm testpassesRelease Notes
Notes:
ServiceWorkerMainclass to interact with service workers in the main process.fromVersionIDonServiceWorkersto get an instance ofServiceWorkerMain.running-status-changedevent onServiceWorkersto indicate when a service worker's running status has changed.startWorkerForScopeonServiceWorkersto start a worker that may have been previously stopped.