Skip to content

fix: handle failing to enter fullscreen on macOS#43151

Merged
codebytere merged 2 commits into
30-x-yfrom
trop/30-x-y-bp-fix-handle-failing-to-enter-fullscreen-on-macos-1722507201147
Aug 1, 2024
Merged

fix: handle failing to enter fullscreen on macOS#43151
codebytere merged 2 commits into
30-x-yfrom
trop/30-x-y-bp-fix-handle-failing-to-enter-fullscreen-on-macos-1722507201147

Conversation

@trop

@trop trop Bot commented Aug 1, 2024

Copy link
Copy Markdown
Contributor

Backport of #43112

See that PR for details.

Notes: Fix behavior when entering/exiting fullscreen fails on macOS.

trop Bot and others added 2 commits August 1, 2024 10:13
On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.

Co-authored-by: cptpcrd <[email protected]>
Seem to be unnecessary since the window exits fullscreen anyway.

Co-authored-by: cptpcrd <[email protected]>
@trop trop Bot requested a review from a team August 1, 2024 10:13
@trop trop Bot added 30-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 1, 2024
@codebytere codebytere merged commit 59e3c0b into 30-x-y Aug 1, 2024
@codebytere codebytere deleted the trop/30-x-y-bp-fix-handle-failing-to-enter-fullscreen-on-macos-1722507201147 branch August 1, 2024 12:50
@release-clerk

release-clerk Bot commented Aug 1, 2024

Copy link
Copy Markdown

Release Notes Persisted

Fix behavior when entering/exiting fullscreen fails on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

30-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant