Skip to content

docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc #43129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ckerr merged 1 commit into from
Aug 2, 2024
Merged

docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc #43129

ckerr merged 1 commit into from
Aug 2, 2024

Conversation

@terrence-ou
Copy link
Contributor

@terrence-ou terrence-ou commented Jul 31, 2024 •
edited by ckerr
Loading

Description of Change

Hello,

I found the electron-fiddle's "Build and Release pipeline" and "Forge configuration" links are broken due to the change of filename. I replaced the broken links with the up-to-date working ones. Thanks for reviewing this PR!

Checklist

Release Notes

Notes: none

@welcome
Copy link

welcome bot commented Jul 31, 2024

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened recently labels Jul 31, 2024
@terrence-ou terrence-ou changed the title docs: fixed broken electron-fiddle build and config links in the Tutorial - Publishing and Updating doc docs: fixed broken electron-fiddle links in the "Tutorial - Publishing and Updating" doc Jul 31, 2024
erickzhao
erickzhao approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

electron-docs-reviewer[bot]
electron-docs-reviewer bot approved these changes Jul 31, 2024
View reviewed changes
Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 1, 2024
@codebytere codebytere added target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. labels Aug 1, 2024
@erickzhao erickzhao removed the target/30-x-y PR should also be added to the "30-x-y" branch. label Aug 1, 2024
@erickzhao
Copy link
Member

erickzhao commented Aug 1, 2024

Removed the target/30-x-y label since we generally only backport up to where it'll get rendered on the site.

@ckerr ckerr merged commit 7c79221 into electron:main Aug 2, 2024
@welcome
Copy link

welcome bot commented Aug 2, 2024

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Aug 2, 2024

No Release Notes

This was referenced Aug 2, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 2, 2024

I have automatically backported this PR to "32-x-y", please check out #43177

@trop trop bot added in-flight/32-x-y and removed target/32-x-y PR should also be added to the "32-x-y" branch. labels Aug 2, 2024
@trop
Copy link
Contributor

trop bot commented Aug 2, 2024

I have automatically backported this PR to "31-x-y", please check out #43178

@trop trop bot added in-flight/31-x-y merged/31-x-y PR was merged to the "31-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. and removed target/31-x-y PR should also be added to the "31-x-y" branch. in-flight/31-x-y labels Aug 2, 2024
@trop trop bot removed the in-flight/32-x-y label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

@electron-docs-reviewer electron-docs-reviewer[bot] electron-docs-reviewer[bot] approved these changes

+1 more reviewer

@erickzhao erickzhao erickzhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation 📓 merged/31-x-y PR was merged to the "31-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terrence-ou @erickzhao @ckerr @codebytere