fix: fix cast in ElectronDesktopWindowTreeHostLinux#42179
Merged
VerteDinde merged 1 commit intoelectron:mainfrom May 14, 2024
Merged
fix: fix cast in ElectronDesktopWindowTreeHostLinux#42179VerteDinde merged 1 commit intoelectron:mainfrom
VerteDinde merged 1 commit intoelectron:mainfrom
Conversation
The frame view of the widget is an `ClientFrameViewLinux` instance only when both `frame` and `client_frame` booleans are set to `true`. Otherwise it is an instance of a different class and thus casting to `ClientFrameViewLinux` is incorrect and leads to crashes. Fix: electron#41839
VerteDinde
added
target/30-x-y
VerteDinde
approved these changes
May 14, 2024
Member
VerteDinde
left a comment
VerteDinde
left a comment
There was a problem hiding this comment.
Amazing, thank you so much for this fix!
VerteDinde
added
the
fast-track 🚅
VerteDinde
changed the title
VerteDinde
changed the title
|
Release Notes Persisted
|
This was referenced May 14, 2024
Contributor
|
I have automatically backported this PR to "31-x-y", please check out #42184 |
trop
bot
added
in-flight/31-x-y
and removed
target/31-x-y
Contributor
|
I have automatically backported this PR to "30-x-y", please check out #42185 |
trop
bot
added
in-flight/30-x-y
merged/30-x-y
trop
bot
added
merged/31-x-y
mnvr
added a commit
to ente-io/ente
that referenced
this pull request
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The frame view of the widget is an
ClientFrameViewLinuxinstance only when bothframeandclient_framebooleans are set totrue. Otherwise it is an instance of a different class and thus casting toClientFrameViewLinuxis incorrect and leads to crashes.Fix: #41839
cc @VerteDinde @ckerr
Checklist
npm testpassesRelease Notes
Notes: Fix crash on window maximize on X11