fix: prevent node mode to be used as script runner by other apps#40579
Merged
deepak1556 merged 1 commit intomainfrom Dec 6, 2023
Merged
fix: prevent node mode to be used as script runner by other apps#40579deepak1556 merged 1 commit intomainfrom
deepak1556 merged 1 commit intomainfrom
Conversation
Contributor
Author
|
/cc @deepak1556 @bpasero this change will get rid of the patch used by VS Code, please check if there will be any unwanted behavior. |
MarshallOfSound
requested changes
Nov 22, 2023
4b35cf5 to
ca110a0
Compare
ca110a0 to
8da3bab
Compare
MarshallOfSound
approved these changes
Dec 5, 2023
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "26-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "27-x-y" cleanly; |
Contributor
|
I have automatically backported this PR to "28-x-y", please check out #40710 |
Contributor
Contributor
MrHuangJser
pushed a commit
to MrHuangJser/electron
that referenced
this pull request
Dec 11, 2023
This was referenced Dec 15, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
See the code comment for the purpose of this change:
Note that this change is only needed on macOS, because on other platforms there is no restriction on invoking another app with custom arguments. In other words, this change is merely to satisfy the security requirements in Apple's ecosystem.
Checklist
npm testpassesRelease Notes
Notes: Prevent node mode to be used as script runner by other apps on macOS.