Skip to content

Conversation

@baparham
Copy link

@baparham baparham commented Nov 7, 2023

Description of Change

Updating Node.js to 18.18.2 to roll to latest security patches from Node.js' Oct 13th security release

See all changes in v18.18.0..18.18.2

Cherry picked from main 7ab2a82 and 6d0d350

Backport of #40174
Backport of #40205

cc: @codebytere @ckerr @jkleinsc

Checklist

Release Notes

Notes: Updated Node.js to latest security release v18.18.2

@baparham baparham requested review from a team as code owners November 7, 2023 13:14
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 7, 2023
@trop trop bot added 28-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Nov 7, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 7, 2023
@baparham
Copy link
Author

baparham commented Nov 7, 2023

oh, shoot, I probably also need to incorporate the changes from #40174 don't I? That may explain why the circle CI builds are failing to apply the patches 🤦

electron-roller bot and others added 2 commits November 7, 2023 14:58
* chore: bump node in DEPS to v18.18.1

* Revert "deps: upgrade to libuv 1.46.0"

nodejs/node#50036

* chore: fixup patch indices

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
* chore: bump node in DEPS to v18.18.2

* chore: update patches

* deps: update nghttp2 to 1.55.0

nodejs/node#48746

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@codebytere codebytere merged commit db99598 into electron:28-x-y Nov 9, 2023
@release-clerk
Copy link

release-clerk bot commented Nov 9, 2023

Release Notes Persisted

Updated Node.js to latest security release v18.18.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

28-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants