build: allow Linux distros to build against system shared libraries - #34841
Merged
Conversation
|
💖 Thanks for opening this pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
zcbenz
reviewed
Jul 11, 2022
Contributor
Author
|
Do you know why the build fails? |
Contributor
|
CI is complaining about patches need to be updated, you can apply this patch to fix it: From dab9ef2c53d220b7442ee2ef5173a7f49207c383 Mon Sep 17 00:00:00 2001
From: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Date: Mon, 11 Jul 2022 10:18:57 +0000
Subject: chore: update patches
diff --git a/patches/node/build_add_gn_build_files.patch b/patches/node/build_add_gn_build_files.patch
index 40fb27d80b71feedae515e88b74d1906b1c4f127..aeed3833e2f0d2e1dc6c9abb9a2371edc5a078b6 100644
--- a/patches/node/build_add_gn_build_files.patch
+++ b/patches/node/build_add_gn_build_files.patch
@@ -7,7 +7,7 @@ This adds GN build files for Node, so we don't have to build with GYP.
diff --git a/BUILD.gn b/BUILD.gn
new file mode 100644
-index 0000000000000000000000000000000000000000..4afca42d22ee702af50da92aa08c1de897891424
+index 0000000000000000000000000000000000000000..9ab5cee8dd9580ada72652f32b44243dbeae89aa
--- /dev/null
+++ b/BUILD.gn
@@ -0,0 +1,440 @@
--
2.34.1 |
Contributor
Author
zcbenz
approved these changes
Jul 13, 2022
Member
|
@brjsp So sorry, would you mind rebasing this branch with main? It looks like our CircleCI run got stuck, and is blocking us from merging this - once that runs, we should be good to go 🙂 |
Add GN flags to build the embedded nodejs copy against system libraries instead of vendored copies in `third_party/electron_node/deps`: * cares * llhttp * nghttp2 * hdr_histogram See also chromium's build/linux/unbundle/README for more Electron-relevant information about vendored dependencies.
Contributor
Author
Contributor
Author
RaisinTen
reviewed
Aug 11, 2022
Co-authored-by: Darshan Sen <[email protected]>
jkleinsc
approved these changes
Aug 17, 2022
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
No Release Notes |
ghost
mentioned this pull request
schetle
pushed a commit
to schetle/electron
that referenced
this pull request
Nov 3, 2022
…lectron#34841) * build: allow Linux distros to build against system shared libraries Add GN flags to build the embedded nodejs copy against system libraries instead of vendored copies in `third_party/electron_node/deps`: * cares * llhttp * nghttp2 * hdr_histogram See also chromium's build/linux/unbundle/README for more Electron-relevant information about vendored dependencies. * Update patches/node/build_add_gn_build_files.patch Co-authored-by: Darshan Sen <[email protected]> Co-authored-by: Darshan Sen <[email protected]>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…lectron#34841) * build: allow Linux distros to build against system shared libraries Add GN flags to build the embedded nodejs copy against system libraries instead of vendored copies in `third_party/electron_node/deps`: * cares * llhttp * nghttp2 * hdr_histogram See also chromium's build/linux/unbundle/README for more Electron-relevant information about vendored dependencies. * Update patches/node/build_add_gn_build_files.patch Co-authored-by: Darshan Sen <[email protected]> Co-authored-by: Darshan Sen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add GN flags that make it easier for downstream packagers to build the embedded nodejs copy in Electron against system libraries instead of vendored copies in
third_party/electron_node/deps:See also chromium's build/linux/unbundle/README for more Electron-relevant information about vendored dependencies.
Checklist
npm testpassesRelease Notes
Notes: none