Skip to content

fix: libuv patches to address child_process.spawn slowness#33406

Merged
jkleinsc merged 5 commits into15-x-yfrom
trop/15-x-y-bp-fix-libuv-patches-to-address-child_process-spawn-slowness-1648042291728
Mar 29, 2022
Merged

fix: libuv patches to address child_process.spawn slowness#33406
jkleinsc merged 5 commits into15-x-yfrom
trop/15-x-y-bp-fix-libuv-patches-to-address-child_process-spawn-slowness-1648042291728

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop bot commented Mar 23, 2022

Backport of #33337

See that PR for details.

Notes: Fixed slowness when using child_process.spawn and related methods on macOS Big Sur and newer.

@trop trop bot requested review from a team as code owners March 23, 2022 13:31
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 23, 2022
@trop trop bot requested a review from nornagon March 23, 2022 13:31
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 23, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 23, 2022
Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patches fail to apply

@deepak1556 deepak1556 self-assigned this Mar 29, 2022
@deepak1556 deepak1556 removed their assignment Mar 29, 2022
@deepak1556 deepak1556 requested a review from jkleinsc March 29, 2022 15:45
@jkleinsc
Copy link
Copy Markdown
Member

Merging as lint has passed but it is not marked in GitHub as such.

@jkleinsc jkleinsc merged commit e5e8dd5 into 15-x-y Mar 29, 2022
@jkleinsc jkleinsc deleted the trop/15-x-y-bp-fix-libuv-patches-to-address-child_process-spawn-slowness-1648042291728 branch March 29, 2022 23:45
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Mar 29, 2022

Release Notes Persisted

Fixed slowness when using child_process.spawn and related methods on macOS Big Sur and newer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants