fix: libuv patches to address child_process.spawn slowness#33337
Merged
deepak1556 merged 2 commits intomainfrom Mar 23, 2022
Merged
fix: libuv patches to address child_process.spawn slowness#33337deepak1556 merged 2 commits intomainfrom
deepak1556 merged 2 commits intomainfrom
Conversation
electron-cation
bot
added
new-pr 🌱
zcbenz
approved these changes
Mar 21, 2022
Member
|
@nornagon the following PRs are also relevant to this backport
Style changes: |
deepak1556
requested changes
Mar 23, 2022
Member
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Marking to avoid accidental merge.
deepak1556
approved these changes
Mar 23, 2022
Member
|
Failing tests are unrelated, merging. |
|
Release Notes Persisted
|
This was referenced Mar 23, 2022
Contributor
|
I have automatically backported this PR to "16-x-y", please check out #33405 |
Contributor
|
I have automatically backported this PR to "15-x-y", please check out #33406 |
Contributor
|
I have automatically backported this PR to "18-x-y", please check out #33407 |
Contributor
|
I have automatically backported this PR to "17-x-y", please check out #33408 |
This was referenced Mar 29, 2022
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
…33337) * fix: libuv patches to address child_process.spawn slowness * chore: backport additional patches Co-authored-by: deepak1556 <[email protected]>
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…33337) * fix: libuv patches to address child_process.spawn slowness * chore: backport additional patches Co-authored-by: deepak1556 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #26143.
This backports six PRs from libuv 1.44.1 to fix slow child_process spawning
behavior on macOS Big Sur and later.
libuv references:
Checklist
npm testpassesRelease Notes
Notes: Fixed slowness when using child_process.spawn and related methods on macOS Big Sur and newer.