chore: deprecate nativeWindowOpen in Electron 17#32116
Merged
Merged
Conversation
nornagon
reviewed
Jan 4, 2022
nornagon
left a comment
nornagon
left a comment
Contributor
There was a problem hiding this comment.
Do we need to add warnings or something? Or are they already in place?
miniak
force-pushed
the
miniak/deprecate-native-window-open
branch
from
5b3bdfa to
811f344
Compare
Contributor
Author
|
@nornagon good point, yes, we should add a warning |
miniak
force-pushed
the
miniak/deprecate-native-window-open
branch
from
811f344 to
292e0b3
Compare
VerteDinde
approved these changes
Jan 6, 2022
zcbenz
approved these changes
Jan 6, 2022
codebytere
approved these changes
Jan 6, 2022
electron-cation
Bot
added
api-review/approved ✅
and removed
api-review/requested 🗳
labels
|
No Release Notes |
Contributor
|
I have automatically backported this PR to "17-x-y", please check out #32368 |
5 tasks
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Prepare for #29405
Checklist
npm testpassesRelease Notes
Notes: none