fix: make sure service worker scheme is registered with allowServiceWorkers#28326
fix: make sure service worker scheme is registered with allowServiceWorkers#28326
Conversation
|
@zcbenz Nice find narrowing down the issue, an alternative approach below. https://github.com/electron/electron/blob/master/patches/chromium/delay_lock_the_protocol_scheme_registry.patch should let us register schemes on the browser process from So we can add a method |
|
@deepak1556 Thanks for the insights on this issue, I have changed the code to add service worker scheme directly instead of full re-registration. |
|
Release Notes Persisted
|
|
I was unable to backport this PR to "10-x-y" cleanly; |
|
I have automatically backported this PR to "11-x-y", please check out #28353 |
|
I have automatically backported this PR to "13-x-y", please check out #28354 |
|
I have automatically backported this PR to "12-x-y", please check out #28355 |
Description of Change
Fix #20248.
The bug was caused by 2 reasons:
registerSchemesAsPrivilegedis called after service worker schemes get registered, so the custom scheme could not be recognized as service worker scheme.Checklist
npm testpassesRelease Notes
Notes: Fix service worker not working with custom protocol.