revert: patch libuv to use posix_spawn on macOS (#27026)#27797
Merged
deepak1556 merged 1 commit intomasterfrom Feb 18, 2021
Merged
revert: patch libuv to use posix_spawn on macOS (#27026)#27797deepak1556 merged 1 commit intomasterfrom
deepak1556 merged 1 commit intomasterfrom
Conversation
This reverts commit f69c111.
VerteDinde
force-pushed
the
revert-posix-spawn
branch
from
77525ac to
f2bc744
Compare
deepak1556
approved these changes
Feb 18, 2021
codebytere
approved these changes
Feb 18, 2021
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "10-x-y" cleanly; |
This was referenced Feb 18, 2021
Contributor
|
I have automatically backported this PR to "11-x-y", please check out #27809 |
Contributor
|
I have automatically backported this PR to "12-x-y", please check out #27810 |
Contributor
|
@VerteDinde has manually backported this PR to "10-x-y", please check out #27811 |
|
Any news on this ? This is severe. Vscode has kept this patch in there code. It's Electron being the most affected. |
3 tasks
|
#26143 Really need a fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Due to failing tests in Node, the posix_spawn change has been reverted in libuv. This PR reverts the patch that applied the change to Electron. This reverts commit f69c111.
Checklist
npm testpassesRelease Notes
Notes: Reverted posix_spawn change in libuv that affected child process spawning on macOS Big Sur.