fix: ECDH.setPrivateKey correctly sets the key #27688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Feb 9, 2021
ckerr
reviewed
Feb 9, 2021
Member
ckerr
left a comment
ckerr
left a comment
There was a problem hiding this comment.
Would it make sense to add a regression test for this?
Contributor
Author
|
@ckerr this undisables the node test which would have caught this. |
jkleinsc
approved these changes
Feb 11, 2021
Member
|
@nornagon mind rebasing? |
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "12-x-y" cleanly; |
Contributor
nornagon
added a commit
that referenced
this pull request
Feb 22, 2021
zcbenz
pushed a commit
that referenced
this pull request
Feb 24, 2021
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #27687.
Checklist
npm testpassesRelease Notes
Notes: Fixed ECDH.setPrivateKey() not updating the key.