Skip to content

fix: make draggable regions work when devtools is opened on macOS#26394

Merged
zcbenz merged 2 commits into10-x-yfrom
trop/10-x-y-bp-fix-make-draggable-regions-work-when-devtools-is-opened-on-macos-1604958862571
Nov 16, 2020
Merged

fix: make draggable regions work when devtools is opened on macOS#26394
zcbenz merged 2 commits into10-x-yfrom
trop/10-x-y-bp-fix-make-draggable-regions-work-when-devtools-is-opened-on-macos-1604958862571

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Nov 9, 2020

Backport of #26361

See that PR for details.

Notes: Fix draggable regions stops working when devtools is opened on macOS

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 9, 2020
@trop trop bot requested a review from zcbenz November 9, 2020 21:54
@trop trop bot mentioned this pull request Nov 9, 2020
Merged
5 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Nov 9, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 9, 2020
codebytere
codebytere previously approved these changes Nov 9, 2020
View reviewed changes
@codebytere codebytere dismissed their stale review November 9, 2020 22:34

build failure

@codebytere
Copy link
Member

codebytere commented Nov 9, 2020 

../../electron/shell/browser/api/electron_api_browser_window_mac.mm:39:21: error: out-of-line definition of 'OnDevToolsResized' does not match any declaration in 'electron::api::BrowserWindow'
void BrowserWindow::OnDevToolsResized() {
                    ^~~~~~~~~~~~~~~~~
1 error generated.
[3 processes, 552/623 @ 8.6/s : 64.546s] OBJCXX obj/electron/electron_framework_shared_library/electron_library_main.o
[2 processes, 553/623 @ 8.2/s : 67.295s] CXX obj/electron/electron_lib/electron_api_app.o
[1 processes, 554/623 @ 6.5/s : 85.323s] CXX obj/electron/electron_lib/tabs_api.o
ninja: build stopped: subcommand failed.

@zcbenz zcbenz force-pushed the trop/10-x-y-bp-fix-make-draggable-regions-work-when-devtools-is-opened-on-macos-1604958862571 branch from 52175a0 to a611574 Compare November 16, 2020 00:33
zcbenz
zcbenz approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failure has been fixed.

@zcbenz zcbenz merged commit 7bd2f0d into 10-x-y Nov 16, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 16, 2020

Release Notes Persisted

Fix draggable regions stops working when devtools is opened on macOS

@zcbenz zcbenz deleted the trop/10-x-y-bp-fix-make-draggable-regions-work-when-devtools-is-opened-on-macos-1604958862571 branch November 16, 2020 06:38
This was referenced Mar 7, 2021
Closed
Closed
Closed
Open
Open
Closed
Closed
Open
Closed
Merged
Closed
Merged
This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere left review comments

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebytere @zcbenz