Skip to content

fix: loading dedicated/shared worker scripts over custom protocol#26142

Merged
deepak1556 merged 1 commit into
8-x-yfrom
miniak/fix_worker_custom_protocol-8-x-y
Oct 29, 2020
Merged

fix: loading dedicated/shared worker scripts over custom protocol#26142
deepak1556 merged 1 commit into
8-x-yfrom
miniak/fix_worker_custom_protocol-8-x-y

Conversation

@miniak

@miniak miniak commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

Backport of #20625

See that PR for details.

Notes:

  • fix loading shared worker scripts over custom protocol
  • fix crash when loading worker scripts with nodeIntegration enabled

@miniak
miniak requested a review from a team as a code owner October 23, 2020 22:42
@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Oct 23, 2020
@trop trop Bot mentioned this pull request Oct 23, 2020
Merged
6 tasks
@trop trop Bot added 8-x-y backport This is a backport PR labels Oct 23, 2020
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Oct 23, 2020
@miniak
miniak force-pushed the miniak/fix_worker_custom_protocol-8-x-y branch from 7a80be3 to be2d0e6 Compare October 23, 2020 22:49
@codebytere

codebytere commented Oct 23, 2020

Copy link
Copy Markdown
Member

@miniak

obj/electron/electron_lib/electron_browser_client.o
../../electron/shell/browser/electron_browser_client.cc:990:7: error: use of undeclared identifier 'ProtocolRegistry'
      ProtocolRegistry::FromBrowserContext(browser_context);
      ^
1 error generated.

@miniak
miniak force-pushed the miniak/fix_worker_custom_protocol-8-x-y branch from be2d0e6 to cccc9b0 Compare October 24, 2020 01:58
@codebytere

codebytere commented Oct 26, 2020

Copy link
Copy Markdown
Member

@miniak this is still failing

@miniak
miniak force-pushed the miniak/fix_worker_custom_protocol-8-x-y branch from cccc9b0 to 2ef211c Compare October 28, 2020 19:48
@miniak

miniak commented Oct 28, 2020

Copy link
Copy Markdown
Contributor Author

@deepak1556 we might need your help here as I am not familiar with this change

@miniak
miniak force-pushed the miniak/fix_worker_custom_protocol-8-x-y branch from 2ef211c to 70ce0ce Compare October 28, 2020 20:56
@miniak

miniak commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

@codebytere fixed

@deepak1556

deepak1556 commented Oct 29, 2020

Copy link
Copy Markdown
Member

Failing test is unrelated, merging.

@deepak1556
deepak1556 merged commit 86e4cce into 8-x-y Oct 29, 2020
@release-clerk

release-clerk Bot commented Oct 29, 2020

Copy link
Copy Markdown

Release Notes Persisted

  • fix loading shared worker scripts over custom protocol
  • fix crash when loading worker scripts with nodeIntegration enabled

@deepak1556
deepak1556 deleted the miniak/fix_worker_custom_protocol-8-x-y branch October 29, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes
@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

8-x-y backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miniak @codebytere @deepak1556