Skip to content

fix: disable CORS when webSecurity is disabled#25463

Merged
nornagon merged 1 commit intomasterfrom
web-security-disable-cors
Sep 16, 2020
Merged

fix: disable CORS when webSecurity is disabled#25463
nornagon merged 1 commit intomasterfrom
web-security-disable-cors

Conversation

@zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Sep 15, 2020

Description of Change

Close #23664.

Chromium has moved some web security controls from blink to browser, this PR updates our code to also disable web security in browser.

Checklist

Release Notes

Notes: Fix CORS not being disabled by webSecurity: false.

@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Sep 15, 2020
@nornagon nornagon merged commit 993eab6 into master Sep 16, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 16, 2020

Release Notes Persisted

Fix CORS not being disabled by webSecurity: false.

@trop
Copy link
Contributor

trop bot commented Sep 16, 2020

I have automatically backported this PR to "10-x-y", please check out #25503

@trop trop bot removed the target/10-x-y label Sep 16, 2020
@trop
Copy link
Contributor

trop bot commented Sep 16, 2020

I have automatically backported this PR to "11-x-y", please check out #25504

@trop
Copy link
Contributor

trop bot commented Sep 16, 2020

I have automatically backported this PR to "9-x-y", please check out #25505

@schacker
Copy link

mark

@circleapps
Copy link

@zcbenz

I saw this PR has been merged to Electron 11.x, but have not been existed on any of Electron 10 release notes.
Could you please tell me when it will be ready for Electron 10.x ? Thanks.

I tested the related issue on Electron 10.2.0, it still persists. Also tried Electron 11, it did fix the issue.

@circleapps
Copy link

I just found 10.1.3 has addressed this issue in its release note, but I can still reproduce it. Not clear why.

@vrunhofen
Copy link

I had issues with an older version where cors wasn't being disabled by setting websecurity to false.
I would get a 'sameorigin' error. So, updated to latest electron (npm version 13.1.3) and it still has the same issue.
Now I get a message in the electron console (not window console) saying "Failed to load URL: https://google.com/ with error: ERR_BLOCKED_BY_RESPONSE

@nornagon
Copy link
Contributor

@vrunhofen please open a new issue with a standalone test case, preferably using Electron Fiddle. Thanks!

Aiz0 added a commit to Aiz0/FreeTube that referenced this pull request Sep 26, 2022
issue was fixed in electron/electron#25463

it will now be disabled when with webSecurity: false
PrestonN pushed a commit to FreeTubeApp/FreeTube that referenced this pull request Sep 26, 2022
issue was fixed in electron/electron#25463

it will now be disabled when with webSecurity: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Electron 9.0.0 webSecurity option no longer disables CORS

7 participants