Conversation
6 tasks
[worker_global_scope.cc(111)] Check failed: url_.IsValid().
codebytere
force-pushed
the
trop/9-x-y-bp-fix-loading-dedicated-shared-worker-scripts-over-custom-protocol-1595900935098
branch
from
August 6, 2020 15:27
011483d to
e0176da
Compare
jkleinsc
requested changes
Aug 17, 2020
jkleinsc
left a comment
jkleinsc
left a comment
Member
There was a problem hiding this comment.
It looks like the new test is failing on WOA
jkleinsc
approved these changes
Aug 17, 2020
|
Release Notes Persisted
|
jkleinsc
deleted the
trop/9-x-y-bp-fix-loading-dedicated-shared-worker-scripts-over-custom-protocol-1595900935098
branch
August 17, 2020 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20625
See that PR for details.
Notes: