fix: loading dedicated/shared worker scripts over custom protocol#24749
Merged
Conversation
[worker_global_scope.cc(111)] Check failed: url_.IsValid().
Backports https://chromium-review.googlesource.com/c/chromium/src/+/1798250 that distinguishes loading the main script resource of dedicated/shared worker, this allows us to register a custom URLLoaderFactory.
6 tasks
codebytere
approved these changes
Aug 6, 2020
|
Release Notes Persisted
|
codebytere
deleted the
trop/10-x-y-bp-fix-loading-dedicated-shared-worker-scripts-over-custom-protocol-1595900932105
branch
August 6, 2020 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20625
See that PR for details.
Notes: