Skip to content

fix: use a WeakPtr so we do not UAF the store in FunctionLifetimeMonitor#22112

Merged
zcbenz merged 1 commit into7-1-xfrom
trop/7-1-x-bp-fix-use-a-weakptr-so-we-do-not-uaf-the-store-in-functionlifetimemonitor-1581223795322
Feb 10, 2020
Merged

fix: use a WeakPtr so we do not UAF the store in FunctionLifetimeMonitor#22112
zcbenz merged 1 commit into7-1-xfrom
trop/7-1-x-bp-fix-use-a-weakptr-so-we-do-not-uaf-the-store-in-functionlifetimemonitor-1581223795322

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Feb 9, 2020

Backport of #22056

See that PR for details.

Notes: Fixed issue where renderers could crash during GC when using the contextBridge module

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 9, 2020
@trop trop bot requested a review from MarshallOfSound February 9, 2020 04:50
@trop trop bot added 7-1-x backport This is a backport PR labels Feb 9, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 9, 2020
@zcbenz zcbenz merged commit a305444 into 7-1-x Feb 10, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 10, 2020

Release Notes Persisted

Fixed issue where renderers could crash during GC when using the contextBridge module

@zcbenz zcbenz deleted the trop/7-1-x-bp-fix-use-a-weakptr-so-we-do-not-uaf-the-store-in-functionlifetimemonitor-1581223795322 branch February 10, 2020 01:47
tessus added a commit to tessus/joplin that referenced this pull request Feb 12, 2020
This is only a minor bump but several issues have been fixed since 7.1.9:

- Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated. electron/electron#21922
- Fixed crash with Date.toLocaleString for invalid locale and locale of the format aa@BB. electron/electron#21969
- Fixed flash plugin not working. electron/electron#22109
- Fixed issue where renderers could crash during GC when using the contextBridge module. electron/electron#22112
- Fixed netLog.stopLogging returning undefined instead of the path to the log. electron/electron#21988
- Fixed an edge case in checkbox logic on Windows. electron/electron#21860
- Fixed an issue where window.print() only worked once on a single BrowserWindow. electron/electron#21911
- Fixed an issue where the credits set in About Panel credits were not dark mode aware on macOS. electron/electron#21924
- Fixed error thrown when importing powerMonitor on Linux before app's 'ready' event. electron/electron#21941
- Fixed fuzzy font rendering when hot-plugging displays on macOS Catalina. electron/electron#21872
- Fixed BrowserWindow.setFocusable(true) not working on Windows. electron/electron#21855
- Fixed set-cookie header not passed in net module. electron/electron#21770
- Fixed an issue where custom stream protocols would sometimes not complete responses when the data stream ended. electron/electron#21758
- Fixed crash when restoring minimized hidden window on Windows. electron/electron#21820
- Fixed issue where non-zero size pixels in CSS styles could be rounded down to zero size pixels. electron/electron#21857
- Fixed memory leak when using javascript generator functions. electron/electron#21773
- Fixed potential hang when sending synchronous IPC messages on process shutdown. electron/electron#21776
laurent22 pushed a commit to laurent22/joplin that referenced this pull request Feb 13, 2020
This is only a minor bump but several issues have been fixed since 7.1.9:

- Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated. electron/electron#21922
- Fixed crash with Date.toLocaleString for invalid locale and locale of the format aa@BB. electron/electron#21969
- Fixed flash plugin not working. electron/electron#22109
- Fixed issue where renderers could crash during GC when using the contextBridge module. electron/electron#22112
- Fixed netLog.stopLogging returning undefined instead of the path to the log. electron/electron#21988
- Fixed an edge case in checkbox logic on Windows. electron/electron#21860
- Fixed an issue where window.print() only worked once on a single BrowserWindow. electron/electron#21911
- Fixed an issue where the credits set in About Panel credits were not dark mode aware on macOS. electron/electron#21924
- Fixed error thrown when importing powerMonitor on Linux before app's 'ready' event. electron/electron#21941
- Fixed fuzzy font rendering when hot-plugging displays on macOS Catalina. electron/electron#21872
- Fixed BrowserWindow.setFocusable(true) not working on Windows. electron/electron#21855
- Fixed set-cookie header not passed in net module. electron/electron#21770
- Fixed an issue where custom stream protocols would sometimes not complete responses when the data stream ended. electron/electron#21758
- Fixed crash when restoring minimized hidden window on Windows. electron/electron#21820
- Fixed issue where non-zero size pixels in CSS styles could be rounded down to zero size pixels. electron/electron#21857
- Fixed memory leak when using javascript generator functions. electron/electron#21773
- Fixed potential hang when sending synchronous IPC messages on process shutdown. electron/electron#21776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7-1-x backport This is a backport PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants