fix: return path from netLog.stopLogging#21985
Merged
MarshallOfSound merged 1 commit intomasterfrom Jan 31, 2020
Merged
Conversation
| const logPath = this._currentlyLoggingPath | ||
| this._currentlyLoggingPath = null | ||
| return _originalStopLogging.call(this) | ||
| return _originalStopLogging.call(this).then(() => logPath) |
felixrieseberg
approved these changes
Jan 31, 2020
nornagon
added
the
fast-track 🚅
Contributor
Author
|
Throwing on [fast-track] to try to get this in before the 8.0.0 stable |
|
Release Notes Persisted
|
This was referenced Jan 31, 2020
Contributor
|
I have automatically backported this PR to "7-1-x", please check out #21988 |
Contributor
|
I have automatically backported this PR to "8-x-y", please check out #21989 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The docs say we return a string, so let's do that. This was broken by the refactor in #18289.
It's a bit weird that we save the path on behalf of the user—all we're doing is keeping track of the value they passed in. That should really be the responsibility of the user, not the API, but since that's how it's documented to work, we might as well make it work the way the docs say (and the way it used to work).
Checklist
npm testpassesRelease Notes
Notes: Fixed netLog.stopLogging returning undefined instead of the path to the log.