refactor: try just using regular [Sync] for MessageSync#21948
Merged
jkleinsc merged 1 commit intoelectron:8-x-yfrom Jan 29, 2020
Merged
refactor: try just using regular [Sync] for MessageSync#21948jkleinsc merged 1 commit intoelectron:8-x-yfrom
jkleinsc merged 1 commit intoelectron:8-x-yfrom
Conversation
6 tasks
erickzhao
changed the title
nornagon
approved these changes
Jan 29, 2020
zcbenz
approved these changes
Jan 29, 2020
jkleinsc
approved these changes
Jan 29, 2020
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20797
See that PR for details. Tested Fiddle show-me for remote and IPC and this did not break anything obvious.
Notes: fixed potential hang when sending synchronous IPC messages on process shutdown