fix: use legacy base::Value serializers for ipc (7-1-x)#21922
Merged
fix: use legacy base::Value serializers for ipc (7-1-x)#21922
Conversation
Contributor
Author
|
|
3 tasks
zcbenz
approved these changes
Jan 29, 2020
Contributor
|
This PR requires approval from @electron/wg-upgrades. |
deepak1556
approved these changes
Jan 31, 2020
Contributor
Author
|
arm is flake, woa is queued forever apparently. I think this is good to go 🚀 |
|
Release Notes Persisted
|
tessus
added a commit
to tessus/joplin
that referenced
this pull request
Feb 12, 2020
This is only a minor bump but several issues have been fixed since 7.1.9: - Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated. electron/electron#21922 - Fixed crash with Date.toLocaleString for invalid locale and locale of the format aa@BB. electron/electron#21969 - Fixed flash plugin not working. electron/electron#22109 - Fixed issue where renderers could crash during GC when using the contextBridge module. electron/electron#22112 - Fixed netLog.stopLogging returning undefined instead of the path to the log. electron/electron#21988 - Fixed an edge case in checkbox logic on Windows. electron/electron#21860 - Fixed an issue where window.print() only worked once on a single BrowserWindow. electron/electron#21911 - Fixed an issue where the credits set in About Panel credits were not dark mode aware on macOS. electron/electron#21924 - Fixed error thrown when importing powerMonitor on Linux before app's 'ready' event. electron/electron#21941 - Fixed fuzzy font rendering when hot-plugging displays on macOS Catalina. electron/electron#21872 - Fixed BrowserWindow.setFocusable(true) not working on Windows. electron/electron#21855 - Fixed set-cookie header not passed in net module. electron/electron#21770 - Fixed an issue where custom stream protocols would sometimes not complete responses when the data stream ended. electron/electron#21758 - Fixed crash when restoring minimized hidden window on Windows. electron/electron#21820 - Fixed issue where non-zero size pixels in CSS styles could be rounded down to zero size pixels. electron/electron#21857 - Fixed memory leak when using javascript generator functions. electron/electron#21773 - Fixed potential hang when sending synchronous IPC messages on process shutdown. electron/electron#21776
laurent22
pushed a commit
to laurent22/joplin
that referenced
this pull request
Feb 13, 2020
This is only a minor bump but several issues have been fixed since 7.1.9: - Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated. electron/electron#21922 - Fixed crash with Date.toLocaleString for invalid locale and locale of the format aa@BB. electron/electron#21969 - Fixed flash plugin not working. electron/electron#22109 - Fixed issue where renderers could crash during GC when using the contextBridge module. electron/electron#22112 - Fixed netLog.stopLogging returning undefined instead of the path to the log. electron/electron#21988 - Fixed an edge case in checkbox logic on Windows. electron/electron#21860 - Fixed an issue where window.print() only worked once on a single BrowserWindow. electron/electron#21911 - Fixed an issue where the credits set in About Panel credits were not dark mode aware on macOS. electron/electron#21924 - Fixed error thrown when importing powerMonitor on Linux before app's 'ready' event. electron/electron#21941 - Fixed fuzzy font rendering when hot-plugging displays on macOS Catalina. electron/electron#21872 - Fixed BrowserWindow.setFocusable(true) not working on Windows. electron/electron#21855 - Fixed set-cookie header not passed in net module. electron/electron#21770 - Fixed an issue where custom stream protocols would sometimes not complete responses when the data stream ended. electron/electron#21758 - Fixed crash when restoring minimized hidden window on Windows. electron/electron#21820 - Fixed issue where non-zero size pixels in CSS styles could be rounded down to zero size pixels. electron/electron#21857 - Fixed memory leak when using javascript generator functions. electron/electron#21773 - Fixed potential hang when sending synchronous IPC messages on process shutdown. electron/electron#21776
Contributor
Author
|
/trop run backport-to 6-1-x |
Contributor
|
The backport process for this PR has been manually initiated - |
Contributor
|
I was unable to backport this PR to "6-1-x" cleanly; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This switches the serialization algorithm for base::ListValue values sent over IPC (through
ipcRenderer/ipcMain) to use the legacy serialization algorithm, rather than the new Mojo algorithm. The messages themselves are still sent over Mojo.Fixes #20334.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where sending complex objects over IPC could in some cases cause the renderer process to be terminated.