Skip to content

fix: window.print() only working once#21913

Merged
zcbenz merged 1 commit into6-1-xfrom
only-print-once-6
Jan 28, 2020
Merged

fix: window.print() only working once#21913
zcbenz merged 1 commit into6-1-xfrom
only-print-once-6

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Jan 27, 2020

Backport of #21893.

See that PR for more details.

Notes: Fixed an issue where window.print() only worked once on a single BrowserWindow.

@codebytere codebytere requested a review from a team as a code owner January 27, 2020 21:09
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 27, 2020
@trop trop bot mentioned this pull request Jan 27, 2020
Merged
4 tasks
@trop trop bot added 6-1-x backport This is a backport PR labels Jan 27, 2020
@codebytere codebytere requested a review from a team January 27, 2020 21:09
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 27, 2020
@zcbenz zcbenz merged commit e020754 into 6-1-x Jan 28, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 28, 2020

Release Notes Persisted

Fixed an issue where window.print() only worked once on a single BrowserWindow.

@zcbenz zcbenz deleted the only-print-once-6 branch January 28, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

+1 more reviewer

@zcbenz zcbenz zcbenz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6-1-x backport This is a backport PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere @ckerr @jkleinsc @zcbenz