fix: window.print() only working once#21893
Merged
codebytere merged 1 commit intomasterfrom Jan 27, 2020
Merged
Conversation
zcbenz
approved these changes
Jan 27, 2020
codebytere
force-pushed
the
fix-printing-only-once
branch
from
5e53cb8 to
2382b6f
Compare
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "8-x-y" cleanly; |
Contributor
|
I was unable to backport this PR to "7-1-x" cleanly; |
Contributor
|
@codebytere has manually backported this PR to "8-x-y", please check out #21908 |
Contributor
|
@codebytere has manually backported this PR to "7-1-x", please check out #21911 |
Contributor
|
@codebytere has manually backported this PR to "6-1-x", please check out #21913 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #21397.
We should be disconnecting from the current print job for
window.print(), unlike forwebContents.print(). This ensures that happens by gating the disconnect call withcallback.is_null(); the callback member is only non-null forwebContents.print().Tested with https://gist.github.com/0f0e776b138452d6815ef4efc16aa0d1 for the following:
webContents.print()andwindow.print()do not crashwebContents.print()andwindow.print()can be called multiple times without failingwebContents.print()orwindow.print()is calledwebContents.print()when it is not called in silent modecc @deepak1556 @nornagon @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
window.print()only worked once on a singleBrowserWindow.