fix: Windows checkboxChecked edge case#21852
Merged
Conversation
codebytere
force-pushed
the
fix-edge-checkbox-case
branch
from
7bae38d to
8fd3fb4
Compare
nornagon
approved these changes
Jan 21, 2020
Contributor
nornagon
left a comment
nornagon
left a comment
There was a problem hiding this comment.
how much check could a checkbox check if a checkbox could check checks?
deepak1556
approved these changes
Jan 21, 2020
zcbenz
approved these changes
Jan 22, 2020
|
Release Notes Persisted
|
This was referenced Jan 22, 2020
Contributor
|
I have automatically backported this PR to "7-1-x", please check out #21860 |
Contributor
|
I have automatically backported this PR to "8-x-y", please check out #21861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #21831.
Most of the checkbox plumbing was fixed earlier, but one edge case remained; if you started with checkbox_checked
false, and then checkedtrue. This final bit:checkbox_checked ? verificationFlagChecked : falseled to the following logic flow:checkboxChecked: false-> user leaved unchecked ->checkboxChecked === false(correct ✅)checkboxChecked: true-> user unchecks ->checkboxChecked === false(correct ✅)checkboxChecked: false-> user checks ->checkboxChecked === false(incorrect 🔴 )checkboxChecked: true-> user leaves checked ->checkboxChecked === true(correct ✅)We shouldn't be gating the final return value on
checkbox_checked; it only reflects the initial checked state. We simply need to returnverificationFlagChecked, as it defaults to false anyway.cc @nornagon @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Fixed an edge case in checkbox logic on Windows.