Skip to content

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Oct 22, 2019

Description of Change

Node added the following commit in v12.10.0 that caused a crash in renderer process initialization becuase we don't directly call NewContext, and so InitializeContext would not create primordials correctly and the following error would occur:

node::Environment::CreateProperties(): Assertion `primordials->IsObject()' failed.

cc @jkleinsc @ckerr @MarshallOfSound

Checklist

Release Notes

Notes: Fixed a crash in Node.js initialization in renderer processes.

@codebytere codebytere requested a review from a team as a code owner October 22, 2019 18:04
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 22, 2019
@codebytere codebytere merged commit 5abce7e into master Oct 23, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 23, 2019

Release Notes Persisted

Fixed a crash in Node.js initialization in renderer processes.

@codebytere codebytere deleted the fix-context-initialize branch October 23, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pr 🌱 PR opened recently

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants