chore: bump chromium to 76.0.3809.73 (6-0-x)#19324
Merged
MarshallOfSound merged 3 commits into6-0-xfrom Jul 19, 2019
Merged
Conversation
MarshallOfSound
requested changes
Jul 18, 2019
Member
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
Legit failure on macOS (looks like we're hitting a CHECK in webContents creation/navigation)
MarshallOfSound
approved these changes
Jul 18, 2019
Member
MarshallOfSound
left a comment
MarshallOfSound
left a comment
There was a problem hiding this comment.
Extracted the Helper changes from the master roll --> #18648
MarshallOfSound
force-pushed
the
roller/chromium/6-0-x
branch
from
235a0de to
1a55bd2
Compare
MarshallOfSound
force-pushed
the
roller/chromium/6-0-x
branch
from
b6ba535 to
702ca8b
Compare
|
Release Notes Persisted
|
Contributor
|
Looks like this is causing this CHECK() to fire, at least in Slack: |
Member
|
@nornagon Let's talk offline, that CHECK won't fire if we're packaging the app correctly. (We need to package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating Chromium to 76.0.3809.73.
See all changes in 76.0.3809.70..76.0.3809.73
Notes: Updated Chromium to 76.0.3809.73.