fix: Correct modal focus behavior on macOS#19061
Merged
codebytere merged 9 commits intoJul 3, 2019
Merged
Conversation
5 tasks
codebytere
approved these changes
Jul 1, 2019
erickzhao
force-pushed
the
trop/4-2-x-bp-fix-correct-modal-focus-behavior-on-macos-1562000859022
branch
from
cb8e7ea to
c567d29
Compare
|
Release Notes Persisted
|
codebytere
deleted the
trop/4-2-x-bp-fix-correct-modal-focus-behavior-on-macos-1562000859022
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18995
See that PR for details.
Notes: Fixed bug on macOS where the main window could be targeted for a
focusevent when it was disabled behind a modal.