chore: bump chromium to f1d9522c04ca8fa0a906f88ababe9 (master) by electron-bot · Pull Request #18648 · electron/electron

electron-bot · 2019-06-05T13:00:33Z

Updating Chromium to f1d9522c04ca8fa0a906f88ababe9 (lkgr).

See all changes in bd6aad6a4b37dad7aae42fec349e9..f1d9522c04ca8fa0a906f88ababe9

Notes: no-notes

MarshallOfSound

If we're doing this we need to add it to the breaking-changes document and add a TODO to deprecate in Electron 6

EDIT: For context this was supposed to be a comment on dcf06eb

GitHub put it as a review comment though 🤷‍♂

spec/chromium-spec.js

nornagon · 2019-06-11T20:54:07Z

@MarshallOfSound i've added it to breaking changes and we should note its deprecation in the 6.0.x release notes (where's the right place for that?)

I'm not sure this warrants a programmatic deprecation warning on the console as that would mean a fair chunk of work to wrap the API in a JS wrapper so that we could call the relevant JS deprecation helper, when currently it's just a direct C++ call. It's a relatively minor API and I think it'd be fine to just document the deprecation—thoughts?

nornagon · 2019-06-12T00:29:17Z

ARM build is failing due to https://crbug.com/972766, stalling until a workaround or fix is implemented.

nornagon · 2019-06-12T00:31:45Z

wait up... why is swiftshader building at all? https://github.com/electron/electron/blob/master/patches/chromium/revert_build_swiftshader_for_arm32.patch this should be preventing it from being built

deepak1556

LGTM

atom/browser/ui/tray_icon_gtk.cc

deepak1556 · 2019-06-14T21:11:30Z

atom/browser/osr/osr_host_display_client.cc

-  }
-
-  shm_mapping_ = shm.Map();
+  shm_mapping_ = region.Map();


While shm_mapping_ is retained by the class, the readable region is only available for the scope of this function, do we want to retain it as well ?

shm_region_ = std::move(region);

I am not sure whats the reason behind retaining shm_mapping_ , /cc @brenca who wrote the initial implementation.

Me either, this code is a mystery to me. The tests pass though? 😬

linux seemed to have related failure https://circleci.com/gh/electron/electron/229118?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link , rerunning it now.

The linux ones are failing consistently.

ah... you're right. okay, i guess we'll have to hold off on merging then.

spec/webview-spec.js

deepak1556 · 2019-06-14T21:35:15Z

I think the arm node inspector failures are a flake ? Since there wasn't a node bump in this PR 🤔

nornagon · 2019-06-14T21:40:14Z

maybe... but both 64 and 32-bit failed the same way. i'll try rerunning.

nornagon · 2019-07-02T21:02:37Z

shell/common/mac/main_application_bundle.mm

  if (!HasMainProcessKey() &&
-      base::EndsWith(path.value(), " Helper", base::CompareCase::SENSITIVE)) {
+      (base::EndsWith(path.value(), " Helper", base::CompareCase::SENSITIVE) ||
+       base::EndsWith(path.value(), content::kMacHelperSuffix_renderer,


kMacHelperSuffix_plugin not allowed?

@nornagon that I know of we are not using the plugin helper; though I guess we could add it here for completeness

@jkleinsc it will be used when pepper plugins are loaded. https://chromium.googlesource.com/chromium/src/+/4be2698e4784b68198d1062a54942ae232c57c24

@deepak1556 ah I forgot about those. I'll add that conditional.

shell/browser/electron_net_log.cc

Can be removed once CL lands upstream. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1685993

This test requires a secure origin so we fake one. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1657952

release-clerk · 2019-07-03T01:22:12Z

No Release Notes

deepak1556 assigned MarshallOfSound Jun 5, 2019

deepak1556 added the wip ⚒ label Jun 5, 2019

electron-bot requested a review from a team as a code owner June 5, 2019 23:25

MarshallOfSound force-pushed the roller/chromium/master branch from c60c1f7 to b45de03 Compare June 5, 2019 23:43

electron-bot changed the title ~~chore: bump chromium to 34b15c3ec28c27db3dc19b26bd12e (master)~~ chore: bump chromium to 165a324273fcb6893f0e1fef42ab1 (master) Jun 6, 2019

electron-bot changed the title ~~chore: bump chromium to 165a324273fcb6893f0e1fef42ab1 (master)~~ chore: bump chromium to f17db08094d8caae3e1407e918af3 (master) Jun 6, 2019

electron-bot changed the title ~~chore: bump chromium to f17db08094d8caae3e1407e918af3 (master)~~ chore: bump chromium to 1b7b73e594e97157ddd539ca335d7 (master) Jun 7, 2019

electron-bot changed the title ~~chore: bump chromium to 1b7b73e594e97157ddd539ca335d7 (master)~~ chore: bump chromium to c1767052ec785c22e2e88b2cb4d8b (master) Jun 7, 2019

MarshallOfSound force-pushed the roller/chromium/master branch from 854355e to 5a8dd1e Compare June 7, 2019 23:02

electron-bot changed the title ~~chore: bump chromium to c1767052ec785c22e2e88b2cb4d8b (master)~~ chore: bump chromium to d13a22b114b95f05590eba74c5471 (master) Jun 8, 2019

electron-bot changed the title ~~chore: bump chromium to d13a22b114b95f05590eba74c5471 (master)~~ chore: bump chromium to 008743d819e298557a53205706e7c (master) Jun 9, 2019

electron-bot changed the title ~~chore: bump chromium to 008743d819e298557a53205706e7c (master)~~ chore: bump chromium to e0ba94b9b94abbb8085bead220228 (master) Jun 10, 2019

nornagon assigned nornagon and unassigned MarshallOfSound Jun 10, 2019

MarshallOfSound reviewed Jun 11, 2019

View reviewed changes

electron-bot changed the title ~~chore: bump chromium to e0ba94b9b94abbb8085bead220228 (master)~~ chore: bump chromium to 2649efd0010cc9dab6d2804f24443 (master) Jun 11, 2019

deepak1556 reviewed Jun 11, 2019

View reviewed changes

spec/chromium-spec.js Outdated Show resolved Hide resolved

electron-bot changed the title ~~chore: bump chromium to 2649efd0010cc9dab6d2804f24443 (master)~~ chore: bump chromium to fdd2b1f6bc312e7d5acca736a3c56 (master) Jun 12, 2019

electron-bot changed the title ~~chore: bump chromium to fdd2b1f6bc312e7d5acca736a3c56 (master)~~ chore: bump chromium to c006d62533f5755043076220181f1 (master) Jun 13, 2019

electron-bot changed the title ~~chore: bump chromium to c006d62533f5755043076220181f1 (master)~~ chore: bump chromium to f27c36631aa274691e333ddecdc22 (master) Jun 14, 2019

deepak1556 reviewed Jun 14, 2019

View reviewed changes

electron-bot changed the title ~~chore: bump chromium to f27c36631aa274691e333ddecdc22 (master)~~ chore: bump chromium to a9584189f87d59d0d1a8548bf6b90 (master) Jun 15, 2019

electron-bot changed the title ~~chore: bump chromium to a9584189f87d59d0d1a8548bf6b90 (master)~~ chore: bump chromium to c86a755a6c49a16ee6876e0db45fb (master) Jun 16, 2019

electron-bot changed the title ~~chore: bump chromium to c86a755a6c49a16ee6876e0db45fb (master)~~ chore: bump chromium to aad9edd83bdfff9954c47d271b75c (master) Jun 17, 2019

electron-bot changed the title ~~chore: bump chromium to aad9edd83bdfff9954c47d271b75c (master)~~ chore: bump chromium to 896a175d791001350324167b1cad3 (master) Jun 18, 2019

electron-bot and others added 12 commits July 2, 2019 13:14

chore: bump chromium in DEPS to c87d16d49a85dc7122781f6c979d354c20f7f78b

73dc685

chore: bump chromium in DEPS to 004bcee2ea336687cedfda8f8a151806ac757d15

1a52057

chore: bump chromium in DEPS to 24428b26a9d15a013b2a253e1084ec3cb54b660b

a7012cb

chore: bump chromium in DEPS to fd25914e875237df88035a6abf89a70bf1360b57

9b6f197

Update patches

7a5e15f

Update node to fix build error

a57d139

Fix compile errors

d0dd035

chore: bump chromium in DEPS to 3062b7cf090f1d9522c04ca8fa0a906f88ababe9

563bb69

chore: update node ref for pushed tags

b822056

chore: update patches for new chromium

03e012c

chore: fix printing patches

e935c49

Use new (10.0.18362) Windows SDK

9aa8313

MarshallOfSound force-pushed the roller/chromium/master branch from 4145564 to 9aa8313 Compare July 2, 2019 20:34

MarshallOfSound removed the wip ⚒ label Jul 2, 2019

nornagon reviewed Jul 2, 2019

View reviewed changes

jkleinsc approved these changes Jul 2, 2019

View reviewed changes

nornagon reviewed Jul 2, 2019

View reviewed changes

shell/browser/electron_net_log.cc Outdated Show resolved Hide resolved

nornagon approved these changes Jul 2, 2019

View reviewed changes

nornagon and others added 7 commits July 2, 2019 14:40

roll node to fix v8 build issues in debug build

8324519

Add support for plugin helper

c3d1884

fix: add patch to fix gpu info enumeration

43fc723

Can be removed once CL lands upstream. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1685993

spec: navigator.requestMIDIAccess now requires a secure origin

adf6b69

This test requires a secure origin so we fake one. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1657952

FIXME: temporarily disable SharedWorker tests

0dca55b

use released version of node-abstractsocket

7e090ed

fix abstract-socket

f5a805e

MarshallOfSound approved these changes Jul 3, 2019

View reviewed changes

MarshallOfSound merged commit 50b9c70 into master Jul 3, 2019

MarshallOfSound deleted the roller/chromium/master branch July 3, 2019 01:22

miniak mentioned this pull request Jul 7, 2019

build: strip recently added swiftshader/libvulkan.so #19141

Merged

3 tasks

Conversation

electron-bot commented Jun 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MarshallOfSound left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nornagon commented Jun 11, 2019

Uh oh!

nornagon commented Jun 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nornagon commented Jun 12, 2019

Uh oh!

deepak1556 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

deepak1556 commented Jun 14, 2019

Uh oh!

nornagon commented Jun 14, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deepak1556 Jul 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

release-clerk bot commented Jul 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

electron-bot commented Jun 5, 2019 •

edited

Loading

MarshallOfSound left a comment •

edited

Loading

nornagon commented Jun 12, 2019 •

edited

Loading

deepak1556 Jul 2, 2019 •

edited

Loading