Skip to content

fix: do not crash when async id check fails (3-1-x) #18456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zcbenz wants to merge 1 commit into from
Closed

fix: do not crash when async id check fails (3-1-x) #18456

zcbenz wants to merge 1 commit into from

Conversation

@zcbenz
Copy link
Contributor

@zcbenz zcbenz commented May 25, 2019

Backport of #18452.

Notes: Fix crash when throwing Error in setImmediate.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 25, 2019
@trop trop bot mentioned this pull request May 25, 2019
Closed
6 tasks
@zcbenz
Copy link
Contributor Author

zcbenz commented May 25, 2019

The Windows CI fails with linking error:

electron_lib.lib(electron_lib.node_bindings.obj) : error LNK2019: unresolved external symbol "void __cdecl node::Assert(char const * (*)[4])" (?Assert@node@@YAXPEAY03QEBD@Z) referenced in function "public: unsigned int const __cd
1889ecl node::AliasedBuffer<unsigned int,class v8::Uint32Array>::GetValue(unsigned __int64)const " (?GetValue@?$AliasedBuffer@IVUint32Array@v8@@@node@@QEBA?BI_K@Z)
1890

which seems not related to this PR.

@zcbenz zcbenz force-pushed the uv-run-once-corruption-3-1-x branch from a6fb661 to 13fb559 Compare May 25, 2019 08:20
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 26, 2019
@zcbenz
Copy link
Contributor Author

zcbenz commented Jun 27, 2019

I'm closing this for now until #18452 is approved.

@zcbenz zcbenz closed this Jun 27, 2019
@codebytere codebytere deleted the uv-run-once-corruption-3-1-x branch October 22, 2019 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zcbenz