refactor: netLog directly uses network service#18289
Merged
Conversation
electron-cation
bot
added
new-pr 🌱
nornagon
force-pushed
the
net-log-refactor
branch
from
e881112 to
c8bef17
Compare
deepak1556
requested changes
May 23, 2019
Member
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
LGTM 👍
couple of code style questions.
deepak1556
approved these changes
May 23, 2019
deepak1556
reviewed
May 23, 2019
Contributor
Author
|
mac failure is flake; merging. |
|
Release Notes Persisted
|
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This refactors the
netLogAPI to directly use the netlog interface exposed by the network service, instead of going throughNetExportFileWriter. As part of the refactor:netLog.startLogging()immediately inapp.on('ready')would silently fail to start the netlog.netLog.startLogging()now returns a promise, which you can await and be sure that the net log has started recording.netLog.currentlyRecordingPathhas been deprecated. If you need access to the currently recording path, you'll have to track it yourself.Checklist
npm testpassesRelease Notes
Notes:
netLog.startLogging()would silently fail when called immediately duringapp.on('ready').netLog.startLogging()now returns a promise which resolves when the net log has started recording.netLog.currentlyLoggingPath.