fix: quit properly in simpleFullScreen mode#14620
Merged
codebytere merged 1 commit intomasterfrom Sep 17, 2018
Merged
Conversation
ckerr
approved these changes
Sep 14, 2018
Contributor
|
@codebytere Can you please rebase onto the latest master? All these failed CI jobs were caused by a broken master =/ |
codebytere
force-pushed
the
fix-simple-fullscreen
branch
from
2872ebe to
9634140
Compare
|
Release Notes Persisted
|
Contributor
|
We have automatically backported this PR to "3-0-x", please check out #14646 |
3 tasks
Member
|
/trop run backport-to 2-0-x |
Contributor
|
The backport process for this PR has been manually initiated, |
Member
Member
Author
|
@MarshallOfSound i put up a manual yesterday, it was linked above :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #13135.
Since borderless windows or windows without titlebars doen't have a close button,
performClose:won't work. Therefore, we instead want to use theclosemethod. However, this method doesn't callwindowShouldClose:on the window's delegate so we manually must call it./cc @sethlu
Checklist
npm testpassesRelease Notes
Notes: fixes issue with app.quit() in simpleFullScreen mode