Skip to content

Upgrade to node v9.3.0 #11507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codebytere merged 10 commits into from
Jan 6, 2018
Merged

Upgrade to node v9.3.0 #11507

codebytere merged 10 commits into from
Jan 6, 2018

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Dec 22, 2017 •
edited
Loading

🙅 do not merge 🙅

/cc @alexeykuzmin

@codebytere codebytere requested a review from a team December 22, 2017 03:06
@alexeykuzmin alexeykuzmin mentioned this pull request Dec 22, 2017
Merged
5 tasks
@zcbenz zcbenz force-pushed the upgrade-to-chromium-62 branch from d2eb942 to 8510778 Compare December 27, 2017 13:01
@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Jan 1, 2018

@codebytere
The upgrade-to-chromium-62 branch has been forcepushed, can you please rebase the node-update-v9.3.0 onto it?

If you have node-update-v9.3.0 checked out locally, this should do the trick:

$ git fetch origin
$ git rebase --onto origin/upgrade-to-chromium-62 54deb37 node-update-v9.3.0

@codebytere codebytere requested review from a team January 3, 2018 18:41
@alexeykuzmin alexeykuzmin force-pushed the upgrade-to-chromium-62 branch from 0aa29ce to b45fb4d Compare January 5, 2018 05:47
@codebytere @deepak1556
REVIEW: Address node api changes
d375b50 
- Always start the inspector agent for nodejs/node#17085
- Set the tracing controller for node nodejs/node#15538
- Isolate data creation now requires plaform nodejs/node#16700
@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Jan 6, 2018

Is it ready to be merged? It looks like CI failures are not related to the new Node.js.

@deepak1556 deepak1556 requested a review from zcbenz January 6, 2018 14:13
@codebytere codebytere merged commit bf5ecaf into upgrade-to-chromium-62 Jan 6, 2018
@codebytere codebytere deleted the node-update-v9.3.0 branch January 14, 2018 01:31
torycl pushed a commit that referenced this pull request Jan 19, 2018
Revert "Upgrade to node v9.3.0 (#11507)"
7fd310a 
This reverts commit bf5ecaf.
zcbenz pushed a commit that referenced this pull request Jan 31, 2018
@codebytere @zcbenz
Upgrade to node v9.3.0 (#11507)
77ec7e3 
* update submodule refs for node v9.3.0

* Define "llvm_version" for Node.js build

* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE

* update NodePlatform to MultiIsolatePlatform

* fix linting error

* update node ref

* REVIEW: Explicitly register builtin modules

nodejs/node#16565

* update libcc ref

* switch libcc to c62

* REVIEW: Address node api changes

- Always start the inspector agent for nodejs/node#17085
- Set the tracing controller for node nodejs/node#15538
- Isolate data creation now requires plaform nodejs/node#16700
alexeykuzmin pushed a commit that referenced this pull request Feb 21, 2018
@codebytere @alexeykuzmin
Upgrade to node v9.3.0 (#11507)
577b71a 
* update submodule refs for node v9.3.0

* Define "llvm_version" for Node.js build

* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE

* update NodePlatform to MultiIsolatePlatform

* fix linting error

* update node ref

* REVIEW: Explicitly register builtin modules

nodejs/node#16565

* update libcc ref

* switch libcc to c62

* REVIEW: Address node api changes

- Always start the inspector agent for nodejs/node#17085
- Set the tracing controller for node nodejs/node#15538
- Isolate data creation now requires plaform nodejs/node#16700
alexeykuzmin pushed a commit that referenced this pull request Feb 22, 2018
@codebytere @alexeykuzmin
Upgrade to node v9.3.0 (#11507)
5624070 
* update submodule refs for node v9.3.0

* Define "llvm_version" for Node.js build

* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE

* update NodePlatform to MultiIsolatePlatform

* fix linting error

* update node ref

* REVIEW: Explicitly register builtin modules

nodejs/node#16565

* update libcc ref

* switch libcc to c62

* REVIEW: Address node api changes

- Always start the inspector agent for nodejs/node#17085
- Set the tracing controller for node nodejs/node#15538
- Isolate data creation now requires plaform nodejs/node#16700
zcbenz pushed a commit that referenced this pull request Feb 23, 2018
@codebytere @zcbenz
Upgrade to node v9.3.0 (#11507)
6c2f7e5 
* update submodule refs for node v9.3.0

* Define "llvm_version" for Node.js build

* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE

* update NodePlatform to MultiIsolatePlatform

* fix linting error

* update node ref

* REVIEW: Explicitly register builtin modules

nodejs/node#16565

* update libcc ref

* switch libcc to c62

* REVIEW: Address node api changes

- Always start the inspector agent for nodejs/node#17085
- Set the tracing controller for node nodejs/node#15538
- Isolate data creation now requires plaform nodejs/node#16700
zcbenz pushed a commit that referenced this pull request Feb 23, 2018
@codebytere @zcbenz
Upgrade to node v9.3.0 (#11507)
0e5b6f9 
* update submodule refs for node v9.3.0

* Define "llvm_version" for Node.js build

* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE

* update NodePlatform to MultiIsolatePlatform

* fix linting error

* update node ref

* REVIEW: Explicitly register builtin modules

nodejs/node#16565

* update libcc ref

* switch libcc to c62

* REVIEW: Address node api changes

- Always start the inspector agent for nodejs/node#17085
- Set the tracing controller for node nodejs/node#15538
- Isolate data creation now requires plaform nodejs/node#16700
sethlu pushed a commit to sethlu/electron that referenced this pull request May 3, 2018
@codebytere @sethlu
Upgrade to node v9.3.0 (electron#11507)
c9a057c 
* update submodule refs for node v9.3.0

* Define "llvm_version" for Node.js build

* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE

* update NodePlatform to MultiIsolatePlatform

* fix linting error

* update node ref

* REVIEW: Explicitly register builtin modules

nodejs/node#16565

* update libcc ref

* switch libcc to c62

* REVIEW: Address node api changes

- Always start the inspector agent for nodejs/node#17085
- Set the tracing controller for node nodejs/node#15538
- Isolate data creation now requires plaform nodejs/node#16700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codebytere @alexeykuzmin @deepak1556