Skip to content

Fix 'BrowserWindow module window states resizable state works for a frameless window' #10280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zcbenz merged 3 commits into from
Aug 21, 2017
Merged

Fix 'BrowserWindow module window states resizable state works for a frameless window' #10280

zcbenz merged 3 commits into from
Aug 21, 2017

Conversation

@alexeykuzmin
Copy link
Contributor

@alexeykuzmin alexeykuzmin commented Aug 16, 2017 •
edited
Loading

It was disabled during Chromium 59 upgrade, see #9946.

@alexeykuzmin alexeykuzmin mentioned this pull request Aug 16, 2017
Merged
2 tasks
@alexeykuzmin
Copy link
Contributor Author

alexeykuzmin commented Aug 21, 2017

Fails on

w = new BrowserWindow({show: false, thickFrame: false})
assert.equal(w.isResizable(), false)  // throws!

@zcbenz, since you have added thickFrame option, could you please take a look?

@zcbenz zcbenz merged commit dede3d6 into master Aug 21, 2017
@zcbenz zcbenz deleted the fix-10280 branch August 21, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexeykuzmin @zcbenz