Skip to content

SharedWorker broken in 7.0 beta #20557

Description

@krisdages

Preflight Checklist

  • [X ] I have read the Contributing Guidelines for this project.
  • [X ] I agree to follow the Code of Conduct that this project adheres to.
  • [X ] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

This is a bug report specifically for the 7.0 beta.

  • Electron Version:
    • 7.0.0-beta.6
  • Operating System:
    • Ubuntu 18.04 x64, Windows 10
  • Last Known Working Electron version:
    • 6.0.12

Expected Behavior

SharedWorker should be functional and shared when using
a custom protocol to provide a proper origin.

Actual Behavior

SharedWorker does not execute when loaded from custom protocol.
It does execute when page is loaded with the file:// protocol, but this
defeats the purpose, since it is not shared between contexts.

Also noticed while diagnosing the issue:
Creating a SharedWorker with node integration enabled using a Data URL crashes
the renderer. I verified that this works in Electron 6, figured the cause might be related.

To Reproduce

Install and run the following repo:

https://github.com/krisdages/electron-7-shared-worker-broken

$ git clone https://github.com/krisdages/electron-7-shared-worker-broken
$ npm install
$ npm start

Sorry, had it implemented before seeing the "electron fiddle" option. May try that next time.

Thanks for looking into this :)

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions