Skip to content

Commit bcc5c51

Browse files
claude[bot]claude
andauthored
test: re-enable Node.js tests that now pass with BoringSSL (#55071)
* test: re-enable Node.js tests that now pass with BoringSSL Most of these were disabled because BoringSSL behaved differently from OpenSSL. Upstream Node.js made the tests BoringSSL-aware in nodejs/node#63161 (v24.18.0) and fixed the ML-KEM expectations in nodejs/node#65966 (v24.22.0), so they now pass. The es-module/test-esm-wasm entry is a stale prefix: test.py matches entries as substrings of the path, so it was hiding 13 split files that pass. A few entries are dropped because the tests now skip themselves. parallel/test-cluster-primary-error, parallel/test-cluster-primary-kill, parallel/test-diagnostics-channel-memory-leak and parallel/test-worker-resource-limits move to the flaky list instead. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M * test: keep two node tests disabled that crash on the testing build test-vm-compile-function-lineoffset hits a V8 Smi::IsValid debug check and test-domain-error-types segfaults under --stress-compaction. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M --------- Co-authored-by: Claude <[email protected]>
1 parent 85825e9 commit bcc5c51

2 files changed

Lines changed: 4 additions & 76 deletions

File tree

‎script/node-disabled-tests.json‎

Lines changed: 0 additions & 76 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
[
2-
"abort/test-abort-backtrace",
3-
"es-module/test-esm-wasm",
42
"es-module/test-esm-wasm-source-phase-dynamic",
53
"es-module/test-esm-wasm-source-phase-identity",
64
"es-module/test-esm-wasm-source-phase-no-execute",
@@ -14,95 +12,22 @@
1412
"parallel/test-bootstrap-modules",
1513
"parallel/test-child-process-fork-exec-path",
1614
"parallel/test-code-cache",
17-
"parallel/test-cluster-primary-error",
18-
"parallel/test-cluster-primary-kill",
19-
"parallel/test-config-file",
20-
"parallel/test-crypto-dh-stateless",
21-
"parallel/test-crypto-fips",
22-
"parallel/test-crypto-keygen",
23-
"parallel/test-crypto-pqc-key-objects-ml-kem",
24-
"parallel/test-crypto-secure-heap",
25-
"parallel/test-diagnostics-channel-memory-leak",
2615
"parallel/test-domain-error-types",
27-
"parallel/test-fs-utimes-y2K38",
28-
"parallel/test-http2-clean-output",
29-
"parallel/test-http2-https-fallback",
30-
"parallel/test-http2-server-unknown-protocol",
31-
"parallel/test-https-agent-session-reuse",
32-
"parallel/test-https-client-renegotiation-limit",
33-
"parallel/test-https-options-boolean-check",
34-
"parallel/test-icu-env",
35-
"parallel/test-icu-minimum-version",
36-
"parallel/test-inspector-port-zero-cluster",
37-
"parallel/test-inspector-tracing-domain",
3816
"parallel/test-module-loading-globalpaths",
39-
"parallel/test-module-print-timing",
4017
"parallel/test-openssl-ca-options",
4118
"parallel/test-os-checked-function",
4219
"parallel/test-process-versions",
43-
"parallel/test-repl-mode",
4420
"parallel/test-promise-swallowed-event",
4521
"parallel/test-repl-underscore",
4622
"parallel/test-runner-v8-deserializer",
4723
"parallel/test-snapshot",
4824
"parallel/test-strace-openat-openssl",
49-
"parallel/test-sqlite-backup",
5025
"parallel/test-max-old-space-size-percentage",
51-
"parallel/test-tls-alpn-server-client",
52-
"parallel/test-tls-cli-min-version-1.0",
53-
"parallel/test-tls-cli-max-version-1.2",
54-
"parallel/test-tls-cli-max-version-1.3",
55-
"parallel/test-tls-cli-min-version-1.1",
56-
"parallel/test-tls-cli-min-version-1.2",
57-
"parallel/test-tls-cli-min-version-1.3",
58-
"parallel/test-tls-client-auth",
59-
"parallel/test-tls-client-getephemeralkeyinfo",
60-
"parallel/test-tls-client-mindhsize",
61-
"parallel/test-tls-client-reject",
62-
"parallel/test-tls-client-renegotiation-13",
6326
"parallel/test-tls-cnnic-whitelist",
64-
"parallel/test-tls-disable-renegotiation",
65-
"parallel/test-tls-empty-sni-context",
66-
"parallel/test-tls-error-stack",
67-
"parallel/test-tls-finished",
68-
"parallel/test-tls-generic-stream",
69-
"parallel/test-tls-getcipher",
70-
"parallel/test-tls-getprotocol",
71-
"parallel/test-tls-handshake-error",
72-
"parallel/test-tls-handshake-exception",
73-
"parallel/test-tls-hello-parser-failure",
74-
"parallel/test-tls-honorcipherorder",
75-
"parallel/test-tls-junk-closes-server",
76-
"parallel/test-tls-junk-server",
77-
"parallel/test-tls-key-mismatch",
78-
"parallel/test-tls-max-send-fragment",
79-
"parallel/test-tls-min-max-version",
80-
"parallel/test-tls-multi-key",
81-
"parallel/test-tls-multi-pfx",
82-
"parallel/test-tls-no-cert-required",
8327
"parallel/test-tls-off-thread-cert-loading",
84-
"parallel/test-tls-options-boolean-check",
85-
"parallel/test-tls-passphrase",
86-
"parallel/test-tls-psk-alpn-callback-exception-handling",
87-
"parallel/test-tls-psk-circuit",
88-
"parallel/test-tls-reduced-SECLEVEL-in-cipher",
89-
"parallel/test-tls-server-failed-handshake-emits-clienterror",
90-
"parallel/test-tls-set-ciphers",
91-
"parallel/test-tls-set-ciphers-error",
92-
"parallel/test-tls-set-default-ca-certificates-extra-override",
93-
"parallel/test-tls-set-default-ca-certificates-recovery",
94-
"parallel/test-tls-set-sigalgs",
95-
"parallel/test-tls-socket-allow-half-open-option",
96-
"parallel/test-tls-socket-failed-handshake-emits-error",
97-
"parallel/test-tls-ticket",
98-
"parallel/test-tls-ticket-cluster",
9928
"parallel/test-trace-events",
100-
"parallel/test-tz-version",
10129
"parallel/test-warn-multipleResolves",
10230
"parallel/test-webcrypto-keygen",
103-
"parallel/test-worker-no-sab",
104-
"parallel/test-worker-resource-limits",
105-
"parallel/test-zlib-unused-weak",
10631
"report/test-report-fatalerror-oomerror",
10732
"report/test-report-getreport",
10833
"report/test-report-signal",
@@ -112,7 +37,6 @@
11237
"report/test-report-worker",
11338
"report/test-report-writereport",
11439
"sea/test-single-executable",
115-
"sequential/test-tls-connect",
11640
"wpt/test-webcrypto",
11741
"wasm-allocation/test-wasm-allocation"
11842
]

‎script/node-flaky-tests.json‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,17 @@
11
[
22
"parallel/test-cluster-bind-privileged-port",
3+
"parallel/test-cluster-primary-error",
4+
"parallel/test-cluster-primary-kill",
35
"parallel/test-cluster-shared-handle-bind-privileged-port",
46
"parallel/test-debugger-random-port-with-inspect-port",
7+
"parallel/test-diagnostics-channel-memory-leak",
58
"parallel/test-fetch",
69
"parallel/test-heapsnapshot-near-heap-limit-by-api-in-worker",
710
"parallel/test-heapsnapshot-near-heap-limit-worker",
811
"parallel/test-inspector-multisession-ws",
912
"parallel/test-inspector-stop-profile-after-done",
1013
"parallel/test-macos-app-sandbox",
14+
"parallel/test-worker-resource-limits",
1115
"sequential/test-cpu-prof-default",
1216
"sequential/test-cpu-prof-dir-absolute",
1317
"sequential/test-cpu-prof-dir-and-name",

0 commit comments

Comments
 (0)